1414064 - Remove or move some disused variables that end up on the link command line

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

As far as I can see, neither WRAP_LDFLAGS nor EXE_DEF_FILE are ever set or do anything useful. Same for SHLIB_LD{START,END}FILE. Similarly, SUB_SHLOBJS is only by used by nss' make build system.

BIN_FLAGS is only set on NETBSD, we could probably stick this in MOZ_PROGRAM_LDFLAGS.

It's a little hard to tell because there's a lot of references to it in nspr and nss, but EXTRA_LIBS seems defunct as well.

LD_VERSION_SCRIPT doesn't seem to be set anywhere. We actually add -version-script some places, but not through this variable.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1414064 - Remove WRAP_LDFLAGS, it is never set in the build system.

Review commit: https://reviewboard.mozilla.org/r/196018/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196018/

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1414064 - Remove EXE_DEF_FILE, it is never set in the build system.

Review commit: https://reviewboard.mozilla.org/r/196020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196020/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1414064 - Remove SHLIB_LD{START,END}FILE and SUB_SHLOBJS.

These are only set by nss' make build system, which we no longer use.

Review commit: https://reviewboard.mozilla.org/r/196022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196022/

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1414064 - Remove references to EXTRA_LIBS in the build system.

Review commit: https://reviewboard.mozilla.org/r/196024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196024/

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1414064 - Move BIN_FLAGS to MOZ_PROGRAM_LDFLAGS, get rid of BIN_FLAGS.

Review commit: https://reviewboard.mozilla.org/r/196026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196026/

Comment 6

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1414064 - Remove LD_VERSION_SCRIPT from the build system.

Review commit: https://reviewboard.mozilla.org/r/196028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196028/

Comment 7

[Michael Shal [:mshal]]

Comment on attachment 8924781 [details]
Bug 1414064 - Remove WRAP_LDFLAGS, it is never set in the build system.

https://reviewboard.mozilla.org/r/196018/#review202326

Comment 8

[Michael Shal [:mshal]]

Comment on attachment 8924782 [details]
Bug 1414064 - Remove EXE_DEF_FILE, it is never set in the build system.

https://reviewboard.mozilla.org/r/196020/#review202328

Comment 9

[Michael Shal [:mshal]]

Comment on attachment 8924783 [details]
Bug 1414064 - Remove SHLIB_LD{START,END}FILE and SUB_SHLOBJS.

https://reviewboard.mozilla.org/r/196022/#review202330

Comment 10

[Michael Shal [:mshal]]

Comment on attachment 8924784 [details]
Bug 1414064 - Remove references to EXTRA_LIBS in the build system.

https://reviewboard.mozilla.org/r/196024/#review202332

I guess it doesn't hurt to leave this in DEPRECATED_VARIABLES? Or should that go away too? https://dxr.mozilla.org/mozilla-central/rev/2535bad09d720e71a982f3f70dd6925f66ab8ec7/python/mozbuild/mozbuild/backend/recursivemake.py#147

Comment 11

[Michael Shal [:mshal]]

Comment on attachment 8924785 [details]
Bug 1414064 - Move BIN_FLAGS to MOZ_PROGRAM_LDFLAGS, get rid of BIN_FLAGS.

https://reviewboard.mozilla.org/r/196026/#review202334

Comment 12

[Michael Shal [:mshal]]

Comment on attachment 8924786 [details]
Bug 1414064 - Remove LD_VERSION_SCRIPT from the build system.

https://reviewboard.mozilla.org/r/196028/#review202350

::: python/mozbuild/mozbuild/frontend/emitter.py:730
(Diff revision 1)
>                          raise SandboxValidationError(
>                              'Path specified in SYMBOLS_FILE does not exist: %s '
>                              '(resolved to %s)' % (symbols_file,
>                              symbols_file.full_path), context)
>                      shared_args['symbols_file'] = True
>                  else:

emitter.py still lists LD_VERSION_SCRIPT as a passthru variable: https://dxr.mozilla.org/mozilla-central/rev/2535bad09d720e71a982f3f70dd6925f66ab8ec7/python/mozbuild/mozbuild/frontend/emitter.py#944

Comment 13

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8924781 [details]
Bug 1414064 - Remove WRAP_LDFLAGS, it is never set in the build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196018/diff/1-2/

Comment 14

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8924782 [details]
Bug 1414064 - Remove EXE_DEF_FILE, it is never set in the build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196020/diff/1-2/

Comment 15

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8924783 [details]
Bug 1414064 - Remove SHLIB_LD{START,END}FILE and SUB_SHLOBJS.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196022/diff/1-2/

Comment 16

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8924784 [details]
Bug 1414064 - Remove references to EXTRA_LIBS in the build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196024/diff/1-2/

Comment 17

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8924785 [details]
Bug 1414064 - Move BIN_FLAGS to MOZ_PROGRAM_LDFLAGS, get rid of BIN_FLAGS.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196026/diff/1-2/

Comment 18

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8924786 [details]
Bug 1414064 - Remove LD_VERSION_SCRIPT from the build system.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196028/diff/1-2/

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11bf83133ab4
Remove WRAP_LDFLAGS, it is never set in the build system. r=mshal
https://hg.mozilla.org/integration/autoland/rev/243303b215cc
Remove EXE_DEF_FILE, it is never set in the build system. r=mshal
https://hg.mozilla.org/integration/autoland/rev/3fcfca0277db
Remove SHLIB_LD{START,END}FILE and SUB_SHLOBJS. r=mshal
https://hg.mozilla.org/integration/autoland/rev/a3e9ac417280
Remove references to EXTRA_LIBS in the build system. r=mshal
https://hg.mozilla.org/integration/autoland/rev/4d3264d16f13
Move BIN_FLAGS to MOZ_PROGRAM_LDFLAGS, get rid of BIN_FLAGS. r=mshal
https://hg.mozilla.org/integration/autoland/rev/0537b09e4117
Remove LD_VERSION_SCRIPT from the build system. r=mshal

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/11bf83133ab4
https://hg.mozilla.org/mozilla-central/rev/243303b215cc
https://hg.mozilla.org/mozilla-central/rev/3fcfca0277db
https://hg.mozilla.org/mozilla-central/rev/a3e9ac417280
https://hg.mozilla.org/mozilla-central/rev/4d3264d16f13
https://hg.mozilla.org/mozilla-central/rev/0537b09e4117