Store the font smoothing background color in ScaledFontMac instead of using GlyphRenderingOptions

RESOLVED FIXED in Firefox 58

Status

()

Core
Graphics
RESOLVED FIXED
17 days ago
14 days ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

17 days ago
This was Lee's idea. It simplifies the code somewhat and makes it easier to pass the color to WebRender.

At the moment, the color makes the following journey:
nsStyleUserInterface::mFontSmoothingBackgroundColor -> gfxContext::fontSmoothingBackgroundColor -> TextRunDrawParams::fontSmoothingBGColor -> GlyphRenderingOptionsCG::mFontSmoothingBackgroundColor.

We can make it take this journey instead:
nsStyleFont::mFont.nsFont::fontSmoothingBackgroundColor -> gfxFontStyle::fontSmoothingBackgroundColor -> gfxMacFont::mFontSmoothingBackgroundColor -> ScaledFontMac::mFontSmoothingBackgroundColor

It's the same number of steps, but the locations make more sense, and this allows us to get rid of GlyphRenderingOptions entirely because Mac was the only platform that used that feature.

The nsStyleUserInterface -> nsStyleFont / nsFont change is being done in bug 1414147.
(Assignee)

Updated

17 days ago
Blocks: 1414157
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 4

17 days ago
mozreview-review
Comment on attachment 8924825 [details]
Bug 1414154 - Store the font smoothing background color on the ScaledFontMac.

https://reviewboard.mozilla.org/r/196066/#review201264
Attachment #8924825 - Flags: review?(lsalzman) → review+

Comment 5

17 days ago
mozreview-review
Comment on attachment 8924826 [details]
Bug 1414154 - Remove GlyphRenderingOptions.

https://reviewboard.mozilla.org/r/196068/#review201266
Attachment #8924826 - Flags: review?(lsalzman) → review+

Comment 6

17 days ago
mozreview-review
Comment on attachment 8924827 [details]
Bug 1414154 - Remove gfxContext::Set/GetFontSmoothingBackgroundColor and TextRunDrawParams::fontSmoothingBGColor.

https://reviewboard.mozilla.org/r/196070/#review201268
Attachment #8924827 - Flags: review?(lsalzman) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

15 days ago
Pushed by mstange@themasta.com:
https://hg.mozilla.org/integration/autoland/rev/d075d05bea93
Store the font smoothing background color on the ScaledFontMac. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/b01be3d4095f
Remove GlyphRenderingOptions. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/71651421a36f
Remove gfxContext::Set/GetFontSmoothingBackgroundColor and TextRunDrawParams::fontSmoothingBGColor. r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/d075d05bea93
https://hg.mozilla.org/mozilla-central/rev/b01be3d4095f
https://hg.mozilla.org/mozilla-central/rev/71651421a36f
Status: ASSIGNED → RESOLVED
Last Resolved: 14 days ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.