1414154 - Store the font smoothing background color in ScaledFontMac instead of using GlyphRenderingOptions

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Markus Stange [:mstange]]

This was Lee's idea. It simplifies the code somewhat and makes it easier to pass the color to WebRender.

At the moment, the color makes the following journey:
nsStyleUserInterface::mFontSmoothingBackgroundColor -> gfxContext::fontSmoothingBackgroundColor -> TextRunDrawParams::fontSmoothingBGColor -> GlyphRenderingOptionsCG::mFontSmoothingBackgroundColor.

We can make it take this journey instead:
nsStyleFont::mFont.nsFont::fontSmoothingBackgroundColor -> gfxFontStyle::fontSmoothingBackgroundColor -> gfxMacFont::mFontSmoothingBackgroundColor -> ScaledFontMac::mFontSmoothingBackgroundColor

It's the same number of steps, but the locations make more sense, and this allows us to get rid of GlyphRenderingOptions entirely because Mac was the only platform that used that feature.

The nsStyleUserInterface -> nsStyleFont / nsFont change is being done in bug 1414147.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1414154 - Store the font smoothing background color on the ScaledFontMac.

Review commit: https://reviewboard.mozilla.org/r/196066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196066/

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1414154 - Remove GlyphRenderingOptions.

Review commit: https://reviewboard.mozilla.org/r/196068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196068/

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1414154 - Remove gfxContext::Set/GetFontSmoothingBackgroundColor and TextRunDrawParams::fontSmoothingBGColor.

Review commit: https://reviewboard.mozilla.org/r/196070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196070/

Comment 4

[Lee Salzman [:lsalzman]]

Comment on attachment 8924825 [details]
Bug 1414154 - Store the font smoothing background color on the ScaledFontMac.

https://reviewboard.mozilla.org/r/196066/#review201264

Comment 5

[Lee Salzman [:lsalzman]]

Comment on attachment 8924826 [details]
Bug 1414154 - Remove GlyphRenderingOptions.

https://reviewboard.mozilla.org/r/196068/#review201266

Comment 6

[Lee Salzman [:lsalzman]]

Comment on attachment 8924827 [details]
Bug 1414154 - Remove gfxContext::Set/GetFontSmoothingBackgroundColor and TextRunDrawParams::fontSmoothingBGColor.

https://reviewboard.mozilla.org/r/196070/#review201268

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8924825 [details]
Bug 1414154 - Store the font smoothing background color on the ScaledFontMac.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196066/diff/1-2/

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8924826 [details]
Bug 1414154 - Remove GlyphRenderingOptions.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196068/diff/1-2/

Comment 9

[Markus Stange [:mstange]]

Comment on attachment 8924827 [details]
Bug 1414154 - Remove gfxContext::Set/GetFontSmoothingBackgroundColor and TextRunDrawParams::fontSmoothingBGColor.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/196070/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d075d05bea93
Store the font smoothing background color on the ScaledFontMac. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/b01be3d4095f
Remove GlyphRenderingOptions. r=lsalzman
https://hg.mozilla.org/integration/autoland/rev/71651421a36f
Remove gfxContext::Set/GetFontSmoothingBackgroundColor and TextRunDrawParams::fontSmoothingBGColor. r=lsalzman

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d075d05bea93
https://hg.mozilla.org/mozilla-central/rev/b01be3d4095f
https://hg.mozilla.org/mozilla-central/rev/71651421a36f