1414224 - Investigate removing the fetch in getTransactionsForTransferItems when dropping/pasting bookmarks

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement, P1)

Description

[Mark Banner (:standard8)]

We currently have a bookmarks fetch in getTransactionsForTransferItems. We should try to avoid this if possible for performance reasons as it is causing extra reads from the disk.

Marco's comments from bug 1410940 comment 4:

Yesterday on IRC we discussed about the case where a user may copy something, make changes, then paste. That's an edge case that may prevent us from just storing the info on copy. I suggested checking if we can pass out the container node from the view.insertionPoint getter, and gather info out of it instead.

Comment 1

[Mark Banner (:standard8)]

Currently, bug 1404909 *may* be removing this additional fetch.

Comment 2

[Mark Banner (:standard8)]

After bug 1404909, we no longer have the fetch, but I've just realised that the functions are still marked as async, so we might as well clean that up.

Comment 3

[Phabricator Automation]

Attachment: Bug 1414224 - Remove unnecessary async annotations around getTransactionsForTransferItems.

MozReview-Commit-ID: 4XEv3IO5YvB

Comment 4

[Phabricator Automation]

Comment on attachment 8984946 [details]
Bug 1414224 - Remove unnecessary async annotations around getTransactionsForTransferItems.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D1611

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e49d6288bd3c
Remove unnecessary async annotations around getTransactionsForTransferItems. r=mak

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e49d6288bd3c