1414367 - FORTIFY_SOURCE compiler checks are incorrect and trigger non-fatal error output "old-configure: 5045: test: test: unexpected operator"

Status: RESOLVED DUPLICATE of bug 1414067

(Core :: Security, defect)

Description

[Daniel Holbert [:dholbert]]

I noticed this in my configure output today:
 0:05.90 checking for dnet_ntoa in -ldnet_stub... (cached) no
 0:05.90 checking for gethostbyname... (cached) yes
 0:05.90 checking for connect... (cached) yes
 0:05.90 checking for remove... (cached) yes
 0:05.90 checking for shmat... (cached) yes
 0:05.90 checking for IceConnectionNumber in -lICE... (cached) yes
 0:05.99 /scratch/work/builds/mozilla-inbound/mozilla/old-configure: 5045: test: test: unexpected operator


That "unexpected operator" thing seemed weird to me. It comes from the "test" expression in this line in old-configure.in:
https://dxr.mozilla.org/mozilla-central/source/old-configure.in#503
> if test "$GNU_CC" -o test -n "${CLANG_CC}${CLANG_CL}"; then

This test expression is invalid.  The second mention of "test" is bogus it really should be:
> if test "$GNU_CC" -o -n "${CLANG_CC}${CLANG_CL}"; then

...since "-o" expects a second *condition*, not an entirely separate-shell-command.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1414367: remove redundant "test" invocation inside of "test" command, in old-configure.in FORTIFY_SOURCE section.

Review commit: https://reviewboard.mozilla.org/r/196350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/196350/

Comment 2

[Daniel Holbert [:dholbert]]

Oh, I guess this is already filed as bug 1414067.