1414383 - Symbolication fails when xcode license isn't accepted

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P1)

Description

[:Harald Kirschner :digitarald]

Had a fresh installed machine restored from backup Time Machine. Symbolication failed until I saw the terminal output that showed the xcode license errors and agreed to the license.

Comment 1

[Julien Wajsberg [:julienw]]

I think this is more an Addon bug ?

Comment 2

[Markus Stange [:mstange]]

Symbolication is handled by the WebExtension API. Here's where we invoke nm:
http://searchfox.org/mozilla-central/rev/af86a58b157fbed26b0e86fcd81f1b421e80e60a/browser/components/extensions/ext-geckoProfiler.js#128-129
That's probably the right place to handle failure.

We would need to test what nm's behavior is when you're in the state where the Xcode license needs to be accepted. It might exit with an error code.

Comment 3

[Graham Perrin]

Cross reference: 

Waiting for symbol tables... · Issue #637 · devtools-html/perf.html
<https://github.com/devtools-html/perf.html/issues/637>

Comment 4

[Greg Tatum [:gregtatum]]

I'm re-prioritizing this as a P1, since this is breaking perf.html for users, which according to that tool is a P1.

Comment 5

[Greg Tatum [:gregtatum]]

Also, it would be nice to throw a helpful user-facing error message that we could display in the perf.html interface, e.g. something like


throw new Error("Symbolication requires the Xcode command line tools to be installed " +
                "and the license accepted. Please run the following from the command " +
                "line to accept the xcode license:\n\n" +
                "sudo xcodebuild -license");

Comment 6

[Nazım Can Altınova [:canova]]

Attachment: Bug 1414383 - Return an error if nm requires xcode license to be accepted during symbolication r?mstange

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39ca0cb416f9
Return an error if nm requires xcode license to be accepted during symbolication r=mstange

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/39ca0cb416f9