1414399 - Refactor test resolving logic out of |mach test|

Status: RESOLVED FIXED

(Testing :: General, enhancement)

Description

[Andrew Halberstadt [:ahal]]

I'd like to use the same logic that |mach test| uses to find tests in a new |mach try| subcommand. This logic currently live in testing/mach_commands.py, which isn't conducive to sharing. I propose we create a new moztest.resolve module for this instead.

This might also be a good opportunity to move the mozbuild.testing.TestResolver class out of mozbuild.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1414399 - [mozbuild/moztest] Move mozbuild.testing.TestResolver to moztest.resolve

The TestMetadata and TestResolver classes aren't technically part of the build
system. The only connection is that they consume some build system output.

The next patch in this series is going to be merging in a bunch of other test
resolving logic from other parts of the tree. Moving this out first allows us
to keep that extra logic out of mozbuild.

Review commit: https://reviewboard.mozilla.org/r/197224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197224/

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1414399 - [moztest] Refactor |mach test|'s resolving logic into moztest.resolve

The code in |mach test| for test resolving, should get merged with the TestResolver
class in moztest.resolve. This way it can be shared with other modules and we'll
have a single canonical place for all our test resolving logic.

Review commit: https://reviewboard.mozilla.org/r/197226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197226/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8926006 [details]
Bug 1414399 - [mozbuild/moztest] Move mozbuild.testing.TestResolver to moztest.resolve

https://reviewboard.mozilla.org/r/197224/#review202494

Yeah, this is only peripherally in the build system. I'm fine with it moving out of mozbuild.

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8926007 [details]
Bug 1414399 - [moztest] Refactor |mach test|'s resolving logic into moztest.resolve

https://reviewboard.mozilla.org/r/197226/#review202496

Seems like a reasonable refactor.

Comment 5

[Geoff Brown [:gbrown]]

Comment on attachment 8926006 [details]
Bug 1414399 - [mozbuild/moztest] Move mozbuild.testing.TestResolver to moztest.resolve

https://reviewboard.mozilla.org/r/197224/#review202506

::: testing/mach_commands.py:520
(Diff revision 1)
>          self._activate_virtualenv()
>          import mozinfo
>          from manifestparser import TestManifest
>  
>          if test_objects is None:
> -            from mozbuild.testing import TestResolver
> +            from moztest.resolve import TestResolver

I see 3 instances of "import TestResolver" in testing/mach_commands.py, but only 2 changes here. Check that you didn't miss one?

Comment 6

[Andrew Halberstadt [:ahal]]

Good catch, thanks Geoff!

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8926006 [details]
Bug 1414399 - [mozbuild/moztest] Move mozbuild.testing.TestResolver to moztest.resolve

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197224/diff/1-2/

Comment 8

[Andrew Halberstadt [:ahal]]

Comment on attachment 8926007 [details]
Bug 1414399 - [moztest] Refactor |mach test|'s resolving logic into moztest.resolve

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197226/diff/1-2/

Comment 9

[Andrew Halberstadt [:ahal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6ba23cd834e592d97c2fd8770054d0a354fbd8a

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1ede5a47bb98
[mozbuild/moztest] Move mozbuild.testing.TestResolver to moztest.resolve r=gps
https://hg.mozilla.org/integration/autoland/rev/3170c6d82e89
[moztest] Refactor |mach test|'s resolving logic into moztest.resolve r=gps

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1ede5a47bb98
https://hg.mozilla.org/mozilla-central/rev/3170c6d82e89