Closed Bug 1414421 Opened 4 years ago Closed 4 years ago
Change MSCOM diagnostic asserts to fire only on Nightly
Let's prevent these from firing on dev edition.
Attachment #8933083 - Flags: review?(jteh) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/08e8c61d3c5a85a9fae9f993092133dbe904abc2 Bug 1414421: Change some diagnostic asserts in mscom to stop firing on dev edition; r=Jamie
Comment on attachment 8933083 [details] [diff] [review] Patch Approval Request Comment [Feature/Bug causing the regression]: a11y+e10s [User impact if declined]: Unnecessary crashing on dev edition [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: No, because this fix does not affect Nightly [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: It makes Dev Edition act the same way as Beta and Release [String changes made/needed]: None
Attachment #8933083 - Flags: approval-mozilla-beta?
Comment on attachment 8933083 [details] [diff] [review] Patch Avoid unnecessary crashing on dev edition. Beta58+.
Attachment #8933083 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Please provide a patch for beta. At least bug 1402519 prevents the central patch from applying on beta. Thank you.
You need to log in before you can comment on or make changes to this bug.