1414451 - Interactive controls in third-party devtools webextensions announced as 'unknown' in NVDA

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marcy Sutton]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.100 Safari/537.36

Steps to reproduce:

- Download and install the latest NVDA screen reader from https://www.nvaccess.org

- Install a third-party webextensions addon (https://github.com/mdn/webextensions-examples/tree/master/devtools-panels)

- Open the devtools and navigate to the third-party addon

- Tab through the controls in the addon


Actual results:

NVDA announces 'unknown' for all interactive controls in the devtools addon. If you hover over them with your mouse, the correct information is heard. But with the keyboard, all we hear is 'unknown'.


Expected results:

NVDA should read accessibility information when the TAB key is pressed.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Check that both documents share the same root. r?aklotz

This may not be 100% right, but it works! Essentially, the extensions document is two documents removed from the AccessibleWrap's document.

Comment 2

[Eitan Isaacson [:eeejay]]

Meaning, the accessible's document is an ancestor, and not a direct parent of the remote doc.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33f70e1ee060
Check that both documents share the same root. r=aklotz

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/33f70e1ee060

Comment 5

[Marco Zehe (:MarcoZ)]

Eitan, is this a candidate for uplift to 58? It's a regression from our Windows E10S a11y work.

Comment 6

[Eitan Isaacson [:eeejay]]

Comment on attachment 8927489 [details] [diff] [review]
Check that both documents share the same root. r?aklotz

Approval Request Comment
[Feature/Bug causing the regression]: a11y e10s
[User impact if declined]: Screen reader users will not be able to access addon devtools panels.
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: STR is in the bug summary.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not positive about the risk. We are early enough in the cycle that we can post followups.
[Why is the change risky/not risky?]:
[String changes made/needed]: None.

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8927489 [details] [diff] [review]
Check that both documents share the same root. r?aklotz

Fix an a11y issue. Beta58+.

Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on the latest Nightly build? Thanks!

Comment 8

[roxleitan]

Reproduced the issue on Windows 10 x64 using Nightly 58.0a1 (2017-11-03).

Verified fixed using the latest Nightly 59.0a1 (2017-11-19)on Windows 10 x64.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/1dedf706dac6

Comment 10

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce the issue described in comment 0 using Firefox 58.0a1 (BuildId:20171103220715).

This issue is verified fixed using Firefox 58.0b5 (BuildId:20171120142222) on Windows 10 64bit with NVDA v 2017.2.