1414454 - checkbox ID reuse causing issue in expertises/interests editing

Status: VERIFIED FIXED

(Mozilla Reps Graveyard :: reps.mozilla.org, task, P1)

Description

[Robert Kaiser]

I found some buggy behavior for this new feature (yes, I was part of the QA team back when MoCo still had something like that). ;-)

In the dialogs to chose mobilizing expertises and learning interests, so of the words can be clicked to mark their checkboxes, some don’t - sounds like some labels are not correctly connected to their checkboxes. On expertise, only “Browser Extensions” and “Testing” work right, on interests, only “Advocacy” works right.
Also, when clicking around a bit, some items are checked when I open the dialog a second time that I actually had not activated - e.g. when I click on the label “Browser Extensions” on interests, the same option on expertise is actually being toggled!

Looking at the source, the two dialogs use the same IDs for the input elements, which is actually invalid HTML and very probably causes this behavior - you can only use any ID once in the whole HTML document (not just in what happens to be visible) - as "Advocacy" only appears once, that's the one thing that really works right at the moment overall :)

Comment 1

[Michael Kohler [:mkohler]]

PR filed here: https://github.com/mozilla/remo/pull/1413

Thanks for reporting!

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/remo

https://github.com/mozilla/remo/commit/5d5ae5faefcc006b8208e6759edd2eea48cec7ba
Merge pull request #1413 from MichaelKohler/feature/bug1414454_mobilizing_undefined_behavior

Fix undefined behaviour of mobilizer selection

Comment 3

[Michael Kohler [:mkohler]]

This is fixed in production.

Comment 4

[Robert Kaiser]

Looks good now, thanks!