1414549 - webRequest.filterResponseData crash

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P1)

Description

[kernp25]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171104100412

Steps to reproduce:

This code:
function listener(details) {
  let filter = browser.webRequest.filterResponseData(details.requestId);
  filter.ondata = event => {
    filter.write(event.data);
    filter.disconnect();
  }
}

browser.webRequest.onBeforeRequest.addListener(
  listener,
  {urls: ["<all_urls>"]},
  ["blocking"]
);

will crash firefox after some short time. If you load some sites (maybe 5?) then firefox will crash.


Actual results:

This is from the crash report:
AdapterDeviceID: 0x5916
AdapterDriverVersion: 21.20.16.4534
AdapterSubsysID: 22cd1b0a
AdapterVendorID: 0x8086
Add-ons: de-DE%40dictionaries.addons.mozilla.org:2.0.6,jid1-s7swGsO2vJBPMv%40jetpack:0.1.7,printedit-we%40DW-dev:20.0,simple-translate%40sienori:1.3.1,en-US%40dictionaries.addons.mozilla.org:8.1,adguardadblocker%40adguard.com:2.7.3,alltabshelper%40alltabshelper.org:1.0.1,aushelper%40mozilla.org:2.0,firefox%40getpocket.com:1.0.5,screenshots%40mozilla.org:19.2.0,shield-recipe-client%40mozilla.org:76.1,webcompat%40mozilla.org:1.1,followonsearch%40mozilla.com:0.9.6,activity-stream%40mozilla.org:2017.11.03.1438-bf427ddd,formautofill%40mozilla.org:1.0,onboarding%40mozilla.org:1.0,flyweb%40mozilla.org:1.0.0,presentation%40mozilla.org:1.0.0,webcompat-reporter%40mozilla.org:1.0.0,%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D:58.0a1
AvailablePageFile: 4159135744
AvailablePhysicalMemory: 3483496448
AvailableVirtualMemory: 3233296384
BIOS_Manufacturer: INSYDE Corp.
BlockedDllList: 
BreakpadReserveAddress: 48234496
BreakpadReserveSize: 83886080
BuildID: 20171104100412
CPUMicrocodeVersion: 0x34
ContentSandboxCapable: 1
ContentSandboxLevel: 4
CrashTime: 1509812405
DOMIPCEnabled: 1
EMCheckCompatibility: true
EventLoopNestingLevel: 1
FramePoisonBase: 0000004041080832
FramePoisonSize: 65536
GPUProcessLaunchCount: 1
GPUProcessStatus: Running
InstallTime: 1509804172
Notes: AdapterVendorID: 0x8086, AdapterDeviceID: 0x5916, AdapterSubsysID: 22cd1b0a, AdapterDriverVersion: 21.20.16.4534
Has dual GPUs. GPU #2: AdapterVendorID2: 0x10de, AdapterDeviceID2: 0x139a, AdapterSubsysID2: 22cd1b0a, AdapterDriverVersion2: 22.21.13.8205FP(D00-L1000-W00001000-T000) DWrite? DWrite+ WR? WR- OMTP? OMTP+ 
ProductID: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
ProductName: Firefox
ReleaseChannel: nightly
SafeMode: 0
SecondsSinceLastCrash: 68315
StartupCrash: 0
StartupTime: 1509804172
SystemMemoryUsePercentage: 58
TelemetryEnvironment: {"build":{"applicationId":"{ec8030f7-c20a-464f-9b0e-13a3a9e97384}","applicationName":"Firefox","architecture":"x86","buildId":"20171104100412","version":"58.0a1","vendor":"Mozilla","platformVersion":"58.0a1","xpcomAbi":"x86-msvc","hotfixVersion":"20170302.01","updaterAvailable":true},"partner":{"distributionId":null,"distributionVersion":null,"partnerId":null,"distributor":null,"distributorChannel":null,"partnerNames":[]},"system":{"memoryMB":8092,"virtualMaxMB":4096,"cpu":{"count":4,"cores":2,"vendor":"GenuineIntel","family":6,"model":142,"stepping":9,"l2cacheKB":256,"l3cacheKB":3072,"speedMHz":2712,"extensions":["hasMMX","hasSSE","hasSSE2","hasSSE3","hasSSSE3","hasSSE4_1","hasSSE4_2","hasAVX","hasAVX2","hasAES"]},"os":{"name":"Windows_NT","version":"10.0","locale":"de-DE","servicePackMajor":0,"servicePackMinor":0,"windowsBuildNumber":15063,"windowsUBR":674,"installYear":2017},"hdd":{"profile":{"model":"S11-128G-PHISON-SSD","revision":"SBFD00.3"},"binary":{"model":"S11-128G-PHISON-SSD","revision":"SBFD00.3"},"system":{"model":"S11-128G-PHISON-SSD","revision":"SBFD00.3"}},"gfx":{"D2DEnabled":false,"DWriteEnabled":true,"ContentBackend":"Skia","adapters":[{"description":"Intel(R) HD Graphics 620","vendorID":"0x8086","deviceID":"0x5916","subsysID":"22cd1b0a","RAM":null,"driver":"igdumdim64 igd10iumd64 igd10iumd64 igd12umd64 igdumdim32 igd10iumd32 igd10iumd32 igd12umd32","driverVersion":"21.20.16.4534","driverDate":"10-7-2016","GPUActive":true},{"description":"NVIDIA GeForce GTX 950M","vendorID":"0x10de","deviceID":"0x139a","subsysID":"22cd1b0a","RAM":4096,"driver":"C:\\WINDOWS\\System32\\DriverStore\\FileRepository\\nvpmwu.inf_amd64_f2045d1eeb288d10\\nvldumdx.dll,C:\\WINDOWS\\System32\\DriverStore\\FileRepository\\nvpmwu.inf_amd64_f2045d1eeb288d10\\nvldumdx.dll,C:\\WINDOWS\\System32\\DriverStore\\FileRepository\\nvpmwu.inf_amd64_f2045d1eeb288d10\\nvldumdx.dll,C:\\WINDOWS\\System32\\DriverStore\\FileRepository\\nvpmwu.inf_amd64_f2045d1eeb288d10\\nvldumdx.dll C:\\WINDOWS\\System32\\DriverStore\\FileRepository\\nvpmwu.inf_amd64_f2045d1eeb288d10\\nvldumd.dll,C:\\WINDOWS\\System32\\DriverStore\\FileRepository\\nvpmwu.inf_amd64_f2045d1eeb288d10\\nvldumd.dll,C:\\WINDOWS\\System32\\DriverStore\\FileRepository\\nvpmwu.inf_amd64_f2045d1eeb288d10\\nvldumd.dll,C:\\WINDOWS\\System32\\DriverStore\\FileRepository\\nvpmwu.inf_amd64_f2045d1eeb288d10\\nvldumd.dll","driverVersion":"22.21.13.8205","driverDate":"5-1-2017","GPUActive":false}],"monitors":[{"screenWidth":1920,"screenHeight":1080,"refreshRate":60,"pseudoDisplay":false}],"features":{"compositor":"d3d11","gpuProcess":{"status":"available"},"advancedLayers":{"status":"available"},"d3d11":{"status":"available","version":45312,"warp":false,"textureSharing":true,"blacklisted":false},"d2d":{"status":"available","version":"1.1"}}},"appleModelId":null,"isWow64":true},"settings":{"blocklistEnabled":true,"e10sEnabled":true,"e10sMultiProcesses":4,"telemetryEnabled":true,"locale":"de","update":{"channel":"nightly","enabled":true,"autoDownload":true},"userPrefs":{"app.update.service.enabled":false,"browser.cache.disk.capacity":358400,"browser.newtabpage.enhanced":true,"browser.shell.checkDefaultBrowser":false,"browser.search.widget.inNavBar":false,"browser.startup.homepage":"<user-set>","browser.urlbar.suggest.searches":false,"devtools.chrome.enabled":true,"devtools.debugger.remote-enabled":true,"privacy.donottrackheader.enabled":true},"sandbox":{"effectiveContentProcessLevel":4},"addonCompatibilityCheckEnabled":true,"isDefaultBrowser":false,"defaultSearchEngine":"google","defaultSearchEngineData":{"name":"Google","loadPath":"jar:[app]/omni.ja!browser/google.xml","origin":"default","submissionURL":"https://www.google.com/search?q=&ie=utf-8&oe=utf-8&client=firefox-b"}},"profile":{"creationDate":17138,"resetDate":17269},"addons":{"activeAddons":{"jid1-s7swGsO2vJBPMv@jetpack":{"version":"0.1.7","scope":1,"type":"extension","updateDay":17292,"isSystem":false,"isWebExtension":true,"multiprocessCompatible":true,"blocklisted":false,"description":"Shows country flag based on the server location for any website","name":"Country Flag +","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17292,"signedState":2},"[e-mail]":{"version":"2.0","scope":1,"type":"extension","updateDay":17431,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"Sets value(s) in the update url based on custom checks.","name":"Application Update Service Helper","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17269},"[e-mail]":{"version":"1.1","scope":1,"type":"extension","updateDay":17431,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"Urgent post-release fixes for web compatibility.","name":"Web Compat","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17269},"[e-mail]":{"version":"19.2.0","scope":1,"type":"extension","updateDay":17451,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":null,"name":"Firefox Screenshots","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17339},"[e-mail]":{"version":"1.0.0","scope":1,"type":"extension","updateDay":17431,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"Discover nearby services in the browser","name":"FlyWeb","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17431},"[e-mail]":{"version":"1.0.0","scope":1,"type":"extension","updateDay":17431,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"Discover nearby devices in the browser","name":"Presentation","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17431},"[e-mail]":{"version":"1.0.0","scope":1,"type":"extension","updateDay":17455,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"Report site compatibility issues on webcompat.com.","name":"WebCompat Reporter","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17455},"simple-translate@sienori":{"version":"1.3.1","scope":1,"type":"extension","updateDay":17464,"isSystem":false,"isWebExtension":true,"multiprocessCompatible":true,"blocklisted":false,"description":"View translations easily as you browse the web.","name":"Simple Translate","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17434,"signedState":2},"[e-mail]":{"version":"2.7.3","scope":1,"type":"extension","updateDay":17464,"isSystem":false,"isWebExtension":true,"multiprocessCompatible":true,"blocklisted":false,"description":"Unübertroffene Werbeblocker-Erweiterung gegen Werbung und Pop-ups. Blockiert Anzeigen auf Facebook, ","name":"Adguard Werbeblocker","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17453,"signedState":2},"[e-mail]":{"version":"0.9.6","scope":1,"type":"extension","updateDay":17466,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":null,"name":"Follow-on Search Telemetry","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17405},"printedit-we@DW-dev":{"version":"20.0","scope":1,"type":"extension","updateDay":17469,"isSystem":false,"isWebExtension":true,"multiprocessCompatible":true,"blocklisted":false,"description":"Edit web pages prior to printing. Delete, hide and format elements. Edit text. Remove adverts and si","name":"Print Edit WE","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17322,"signedState":2},"[e-mail]":{"version":"1.0.5","scope":1,"type":"extension","updateDay":17471,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"When you find something you want to view later, put it in Pocket.","name":"Pocket","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17269},"[e-mail]":{"version":"1.0","scope":1,"type":"extension","updateDay":17472,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"Photon onboarding","name":"Photon onboarding","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17435},"[e-mail]":{"version":"76.1","scope":1,"type":"extension","updateDay":17473,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"Client to download and run recipes for SHIELD, Heartbeat, etc.","name":"Shield Recipe Client","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17405},"[e-mail]":{"version":"1.0.1","scope":1,"type":"extension","updateDay":17474,"isSystem":false,"isWebExtension":true,"multiprocessCompatible":true,"blocklisted":false,"description":"All Tabs Helper","name":"All Tabs Helper","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17474,"signedState":2},"[e-mail]":{"version":"2017.11.03.1438-bf427ddd","scope":1,"type":"extension","updateDay":17474,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"A rich visual history feed and a reimagined home page make it easier than ever to find exactly what ","name":"Activity Stream","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17435},"[e-mail]":{"version":"1.0","scope":1,"type":"extension","updateDay":17474,"isSystem":true,"isWebExtension":false,"multiprocessCompatible":true,"blocklisted":false,"description":"Autofill forms with saved profiles","name":"Form Autofill","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17435},"cb1e827c28e586da542b5c5391ab3980de2e3902@temporary-addon":{"version":"1.0","scope":16,"type":"extension","updateDay":17434,"isWebExtension":true,"multiprocessCompatible":true,"blocklisted":false,"description":"Altering HTTP responses","name":"http-response-filter","userDisabled":false,"appDisabled":false,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17474,"signedState":0}},"theme":{"id":"{972ce4c6-7e08-4474-a285-3208198ce6fd}","blocklisted":false,"description":"Das Standard-Theme.","name":"Standard","userDisabled":false,"appDisabled":false,"version":"58.0a1","scope":4,"foreignInstall":false,"hasBinaryComponents":false,"installDay":17269,"updateDay":17473},"activePlugins":[{"name":"Shockwave Flash","version":"27.0.0.183","description":"Shockwave Flash 27.0 r0","blocklisted":false,"disabled":false,"clicktoplay":true,"mimeTypes":["application/x-shockwave-flash","application/futuresplash"],"updateDay":17464}],"activeGMPlugins":{"gmp-gmpopenh264":{"version":"1.7.1","userDisabled":false,"applyBackgroundUpdates":1},"gmp-widevinecdm":{"version":"1.4.8.1008","userDisabled":false,"applyBackgroundUpdates":1}},"activeExperiment":{},"persona":null}}
Theme: classic/1.0
ThreadIdNameMapping: 7784:"Gecko_IOThread",7128:"Timer",7856:"Link Monitor",11912:"Socket Thread",10268:"JS Watchdog",2360:"BGReadURLs",14548:"Hang Monitor",2176:"BgHangManager",10280:"Cache2 I/O",4148:"Cookie",16260:"GMPThread",17492:"VsyncIOThread",10880:"WindowsVsyncThread",16008:"Compositor",13920:"VRListener",9760:"ImgDecoder #1",13296:"ImgDecoder #2",16552:"ImgDecoder #3",5060:"ImageIO",9728:"HTML5 Parser",8976:"IPDL Background",7652:"ImageBridgeChild",8688:"ProcessHangMon",5224:"LoadRoots",18180:"SysProxySetting",4376:"ProxyResolution",18320:"SaveScripts",11924:"Cache I/O",14692:"DataStorage",14888:"URL Classifier",17996:"Classifier Update",16972:"DataStorage",19004:"DataStorage",6524:"mozStorage #1",2320:"DOM Worker",13620:"mozStorage #2",14688:"mozStorage #3",16236:"localStorage DB",4052:"mozStorage #4",18764:"QuotaManager IO",4024:"mozStorage #5",7768:"DOM Worker",13116:"PlayEventSound",8480:"mozStorage #6",17560:"DNS Resolver #24",13540:"DNS Resolver #25",2052:"DOM Worker",16724:"SSL Cert #91",17428:"DNS Resolver #27",5168:"SSL Cert #92",13864:"DNS Resolver #28",10024:"DNS Resolver #29",18160:"DNS Resolver #30",12616:"DNS Resolver #31",10804:"SSL Cert #93",16356:"StreamTrans #89",12108:"DOM Worker",17816:"EncodingRunnable #14",
Throttleable: 1
TotalPageFile: 11163627520
TotalPhysicalMemory: 8485310464
TotalVirtualMemory: 4294836224
UptimeTS: 21807.948562335
Vendor: Mozilla
Version: 58.0a1
Winsock_LSP: Hyper-V RAW : 2 : 34 : 1 : 1 : 0x20026 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : 1234191b-4bf7-4ca7-86e0-dfd7c32b5445 
 MSAFD-Tcpip [TCP/IP] : 2 : 2 : 1 : 6 : 0x20066 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : e70f1aa0-ab8b-11cf-8ca3-00805f48a192 
 MSAFD-Tcpip [UDP/IP] : 2 : 2 : 2 : 17 : 0x20609 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : e70f1aa0-ab8b-11cf-8ca3-00805f48a192 
 MSAFD-Tcpip [RAW/IP] : 2 : 2 : 3 : 0 : 0x20609 : 0xc : %SystemRoot%\system32\mswsock.dll :  : e70f1aa0-ab8b-11cf-8ca3-00805f48a192 
 MSAFD-Tcpip [TCP/IPv6] : 2 : 23 : 1 : 6 : 0x20066 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : f9eab0c0-26d4-11d0-bbbf-00aa006c34e4 
 MSAFD-Tcpip [UDP/IPv6] : 2 : 23 : 2 : 17 : 0x20609 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : f9eab0c0-26d4-11d0-bbbf-00aa006c34e4 
 MSAFD-Tcpip [RAW/IPv6] : 2 : 23 : 3 : 0 : 0x20609 : 0xc : %SystemRoot%\system32\mswsock.dll :  : f9eab0c0-26d4-11d0-bbbf-00aa006c34e4 
 RSVP-TCPv6-Dienstanbieter : 2 : 23 : 1 : 6 : 0x22066 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : 9d60a9e0-337a-11d0-bd88-0000c082e69a 
 RSVP-TCP-Dienstanbieter : 2 : 2 : 1 : 6 : 0x22066 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : 9d60a9e0-337a-11d0-bd88-0000c082e69a 
 RSVP-UDPv6-Dienstanbieter : 2 : 23 : 2 : 17 : 0x22609 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : 9d60a9e0-337a-11d0-bd88-0000c082e69a 
 RSVP-UDP-Dienstanbieter : 2 : 2 : 2 : 17 : 0x22609 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : 9d60a9e0-337a-11d0-bd88-0000c082e69a 
 MSAFD Irda [IrDA] : 2 : 26 : 1 : 1 : 0x20006 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : 3972523d-2af1-11d1-b655-00805f3642cc 
 MSAFD RfComm [Bluetooth] : 2 : 32 : 1 : 3 : 0x20026 : 0x8 : %SystemRoot%\system32\mswsock.dll :  : 9fc48064-7298-43e4-b7bd-181f2089792a
useragent_locale: de

Diese Meldung enthält Informationen über den Status der Anwendung zum Zeitpunkt des Absturzes.


Expected results:

Firefox should not crash. WebExtensions should never crash the browser.

Comment 1

[Kris Maglione [:kmag]]

Do you have a crash report?

Comment 2

[kernp25]

I think this is the crash report for the problem:
https://crash-stats.mozilla.com/report/index/4831c33a-90b1-422a-afa4-8f0960171105

I'm also seeing this report:
https://crash-stats.mozilla.com/report/index/66a5832f-bdf1-46bd-bf75-2350a0171105

Comment 3

[kernp25]

Without the filterResponseData the crash will not occur.

Comment 4

[kernp25]

https://crash-stats.mozilla.com/report/index/0d4d2561-3ead-4316-b15f-c84c70171105

Comment 5

[Andy McKay]

Kris, marking as P1 assuming we might want to aim for 57, possibly once you've investigated?

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1414549: Correctly handle GetDeliveryTarget failure.

getter_AddRefs nulls its parameter before passing it to the getter function,
which means that on failure, we wind up with a null IO thread, rather than its
original main thread value.

Review commit: https://reviewboard.mozilla.org/r/197794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197794/

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8926563 [details]
Bug 1414549: Correctly handle GetDeliveryTarget failure.

https://reviewboard.mozilla.org/r/197794/#review203008

Comment 8

[Kris Maglione [:kmag]]

Comment on attachment 8926563 [details]
Bug 1414549: Correctly handle GetDeliveryTarget failure.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1405286
[User impact if declined]: This bug causes crashes under certain unpredictable circumstances when extensions use the web request filter API.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No, but I've verified it locally.
[Needs manual test from QE? If yes, steps to reproduce]: Ideally, the reporter should verify.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's a trivial error checking fix which simply prevents an important member variable from being set to null after a non-fatal failure.
[String changes made/needed]: None.

Comment 9

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67462ac2d7142c01ffab6064738cdf7efbe2c01e
Bug 1414549: Correctly handle GetDeliveryTarget failure. r=mixedpuppy

Comment 10

[Andy McKay]

At this point this API is infrequently used. However we are expecting NoScript to port over to using this API and that's 2 million users who might get NoScript and might hit this crash. Normally I'd ping Giorgio on the use of this API, but given the timezone that might take a day or so.

This seems relatively low risk, but a high reward if it prevents those crashes.

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8926563 [details]
Bug 1414549: Correctly handle GetDeliveryTarget failure.

I trust Kris and Andy's risk-reward assessment on this one, this will be in 57 RC2.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/67462ac2d714

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/05cea48ce769

Comment 14

[kernp25]

https://bugzilla.mozilla.org/show_bug.cgi?id=1416227

Comment 15

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe verify-“ flag.

Thanks!