Closed
Bug 1414616
Opened 7 years ago
Closed 6 years ago
"Take a Screenshot" string not localized
Categories
(Firefox :: Screenshots, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: rimas, Assigned: adw)
References
Details
Attachments
(1 file)
32.38 KB,
image/png
|
Details |
It looks like the "Take a Screenshot" string in the address bar menu is not being exposed for Localization. A similar string in the context menu of web pages IS localized. Attaching a screenshot made on the latest Linux nightly (58.0a1 (2017-11-04) (64 bit)). On #l10n another localizer confirmed that this issue exists in their locale as well.
Reporter | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
I have 19.2.0 in both Beta (57.b14) and Nightly, and only in Nightly it shows up not localized. I wonder if it's due to external changes. Unfortunately, mozregression can't be used with localize builds.
Updated•7 years ago
|
Assignee: nobody → jhirsch
Comment 3•7 years ago
|
||
This appears to be a legit bug. The page action label is initially set to 'Take a Screenshot'[1]. Slightly later, the webextension code fires over the localized page action label[2], which is then reset in bootstrap[3]. Looks like steps [1] and [2] still work, but [3] no longer works: if I replace that line with a line that sets the pageAction.title to "Hello World", the UI is not updated. :adw, any idea if this API has changed recently? I'm opening a tracking bug on Github, because we do our sprint planning there[4]. Happy to keep the conversation here, as I suspect this is an upstream Gecko bug. Note that any patches will need to land in both sides. [1] https://dxr.mozilla.org/mozilla-central/source/browser/extensions/screenshots/bootstrap.js#246 [2] https://dxr.mozilla.org/mozilla-central/source/browser/extensions/screenshots/webextension/background/startBackground.js#152 [3] https://dxr.mozilla.org/mozilla-central/source/browser/extensions/screenshots/bootstrap.js#271 [4] Thttps://github.com/mozilla-services/screenshots/issues/3732
Flags: needinfo?(adw)
Assignee | ||
Comment 4•7 years ago
|
||
Thanks for filing this! I messed up when I fixed bug 1395387. I changed the PageActions.Action `title` setter to a setTitle() method in the API but didn't update the screenshots consumer here. Same for `iconURL`. It should be setIconURL() now. The unlocalized title is expected because it's replaced with the actual localized title immediately (or should be, except for this bug).
Flags: needinfo?(adw)
Assignee | ||
Comment 5•7 years ago
|
||
Jared, I see that you're assigned to this bug, but if you'd like me to take it, I'd be happy to, just let me know.
Comment 6•7 years ago
|
||
Hey Drew - That would be great, thanks! Reassigning to you.
Assignee: jhirsch → adw
Assignee | ||
Comment 7•7 years ago
|
||
I made a PR here: https://github.com/mozilla-services/screenshots/pull/3739
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•7 years ago
|
||
Ian merged the PR, so we can close this bug when screenshots is merged to m-c.
Comment 9•6 years ago
|
||
I can confirm that 59 is OK, but 58 is not. What are the next steps here?
Flags: needinfo?(adw)
Assignee | ||
Comment 10•6 years ago
|
||
The next step is to merge the screenshots GitHub repo to mozilla-central. That's Ian and his team, so I'll redirect the needinfo to him.
Flags: needinfo?(adw) → needinfo?(ianb)
Comment 11•6 years ago
|
||
It's part of the 25.0.0 export in Bug 1419148. We are planning on requesting uplift for that version into 58.
Depends on: 1419148
Flags: needinfo?(ianb)
Comment 12•6 years ago
|
||
This landed in Nightly and we're requesting uplift to beta.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 13•1 year ago
|
||
I have verified this issue using the latest Firefox Release 108.0 (Build ID: 20221208122842) on Windows 10x64, macOS 12.6 and Linux Mint 20.2 and I can confirm the following:
- The "Screenshot" string is now correctly localized.
Status: RESOLVED → VERIFIED
status-firefox109:
--- → verified
Updated•1 year ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•