Closed Bug 1414638 Opened 7 years ago Closed 7 years ago

Remove support for expiry_date field from events registry

Categories

(Toolkit :: Telemetry, enhancement, P1)

Product:
Toolkit
Component:
Telemetry
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: gfritzsche, Assigned: gfritzsche)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Remove expiry_date property for Telemetry events
15.64 KB, patch
gfritzsche
: review+
Details | Diff | Splinter Review
We thought expiry_date could be a solution to get more dynamic expiry started for events. This was never used so far and we went a different path for add-on event expiry. Consequently i'm removing this now.
Attachment #8925361 - Flags: review?(alessio.placitelli)
Comment on attachment 8925361 [details] [diff] [review] Remove expiry_date property for Telemetry events Review of attachment 8925361 [details] [diff] [review]: ----------------------------------------------------------------- Looks good with the nit below addressed! ::: toolkit/components/telemetry/docs/collection/events.rst @@ +230,5 @@ > - Firefox 56: Added support for recording new probes from add-ons (`bug 1302681 <bug https://bugzilla.mozilla.org/show_bug.cgi?id=1302681>`_). > +- Firefox 58: > + > + - Ignore re-registering existing events for a category instead of failing (`bug 1408975 <https://bugzilla.mozilla.org/show_bug.cgi?id=1408975>`_). > + - Removed support for the ``expiry_date`` property, as it was unused (`bug xxx <https://bugzilla.mozilla.org/show_bug.cgi?id=xxx>`_). Looks like this is missing the bug number: "xxx" :)
Attachment #8925361 - Flags: review?(alessio.placitelli) → review+
Attachment #8925361 - Attachment is obsolete: true
Attachment #8925504 - Flags: review+
Pushed by georg.fritzsche@googlemail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a94b8078bb5c Remove expiry_date property for Telemetry events. r=dexter
Pushed by georg.fritzsche@googlemail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ceeec2fbbfc1 Remove expiry_date property for Telemetry events. r=dexter
https://hg.mozilla.org/mozilla-central/rev/ceeec2fbbfc1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Flags: needinfo?(gfritzsche)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: