Closed
Bug 1414638
Opened 7 years ago
Closed 7 years ago
Remove support for expiry_date field from events registry
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: gfritzsche)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
15.64 KB,
patch
|
gfritzsche
:
review+
|
Details | Diff | Splinter Review |
We thought expiry_date could be a solution to get more dynamic expiry started for events. This was never used so far and we went a different path for add-on event expiry. Consequently i'm removing this now.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8925361 -
Flags: review?(alessio.placitelli)
|
|
Assignee | |
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c42dc986df5effa059d5fae646ede9eb84c7711
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8925361 [details] [diff] [review] Remove expiry_date property for Telemetry events Review of attachment 8925361 [details] [diff] [review]: ----------------------------------------------------------------- Looks good with the nit below addressed! ::: toolkit/components/telemetry/docs/collection/events.rst @@ +230,5 @@ > - Firefox 56: Added support for recording new probes from add-ons (`bug 1302681 <bug https://bugzilla.mozilla.org/show_bug.cgi?id=1302681>`_). > +- Firefox 58: > + > + - Ignore re-registering existing events for a category instead of failing (`bug 1408975 <https://bugzilla.mozilla.org/show_bug.cgi?id=1408975>`_). > + - Removed support for the ``expiry_date`` property, as it was unused (`bug xxx <https://bugzilla.mozilla.org/show_bug.cgi?id=xxx>`_). Looks like this is missing the bug number: "xxx" :)
Attachment #8925361 -
Flags: review?(alessio.placitelli) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8925361 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8925504 -
Flags: review+
Pushed by georg.fritzsche@googlemail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a94b8078bb5c Remove expiry_date property for Telemetry events. r=dexter
|
||
Comment 6•7 years ago
|
||
Backed out so bug 1408975 can be backed out: https://hg.mozilla.org/integration/mozilla-inbound/rev/3408eeb95298aac0703f5f9c39f86d218428c85f
Flags: needinfo?(gfritzsche)
Pushed by georg.fritzsche@googlemail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ceeec2fbbfc1 Remove expiry_date property for Telemetry events. r=dexter
|
|
||
Comment 8•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ceeec2fbbfc1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(gfritzsche)
You need to log in
before you can comment on or make changes to this bug.
Description
•