Closed
Bug 1414714
Opened 7 years ago
Closed 7 years ago
Remove some unused gfx prefs
Categories
(Core :: Graphics, enhancement, P3)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: cyu, Assigned: cyu)
References
(Blocks 1 open bug)
Details
(Whiteboard: [gfx-noted])
Attachments
(3 files)
|
1.64 KB,
patch
|
chutten
:
review+
|
Details | Diff | Splinter Review |
|
5.10 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
|
8.99 KB,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
We have some prefs that are declared in all.js, defined in gfxPrefs.h/cpp, but are not accessed anywhere in our code base. They can be easily removed.
|
Assignee | |
Comment 1•7 years ago
|
||
Assignee: nobody → cyu
Attachment #8925457 -
Flags: review?(chutten)
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8925460 -
Flags: review?(nical.bugzilla)
|
||
Updated•7 years ago
|
Attachment #8925460 -
Flags: review?(nical.bugzilla) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
This is for prefs not starting with gfx.*
Attachment #8925481 -
Flags: review?(nical.bugzilla)
|
||
Comment 4•7 years ago
|
||
Comment on attachment 8925457 [details] [diff] [review]
Part 1: Remove unused telemetry environment pref "gfx.direct2d.use1_1".
Review of attachment 8925457 [details] [diff] [review]:
-----------------------------------------------------------------
Happy to see code go away.
Attachment #8925457 -
Flags: review?(chutten) → review+
|
||
Updated•7 years ago
|
|
|
||
Updated•7 years ago
|
Attachment #8925481 -
Flags: review?(nical.bugzilla) → review+
|
|
Assignee | |
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4cc9b54397e5411bc6eff5812fa314201441b7e
Bug 1414714 - Part 1: Remove unused telemetry environment pref "gfx.direct2d.use1_1". r=chutten
https://hg.mozilla.org/integration/mozilla-inbound/rev/06e41f47f05d0572d77fccfa6fdb87eb2c938d4b
Bug 1414714 - Part 2: Remove unused gfx.* prefs. r=nical
https://hg.mozilla.org/integration/mozilla-inbound/rev/71662dbd44ed3f88412168ee0adb044dcee03966
Bug 1414714 - Part 3: Remove more unused prefs defined in gfxPrefs. r=nical
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a4cc9b54397e
https://hg.mozilla.org/mozilla-central/rev/06e41f47f05d
https://hg.mozilla.org/mozilla-central/rev/71662dbd44ed
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•