Closed Bug 1414751 Opened 8 years ago Closed 2 months ago

Intermittent test-verify browser/components/preferences/in-content/tests/browser_siteData.js | Should list sites using quota usage or appcache - Got 1, expected 2

Categories

(Core :: Storage: Quota Manager, defect, P2)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled]DWS_NEXT, dom-lws-bugdash-triage)

Attachments

(2 files)

Filed by: archaeopteryx [at] coole-files.de https://treeherder.mozilla.org/logviewer.html#?job_id=142288351&repo=autoland https://queue.taskcluster.net/v1/task/SaqfdNb5TPSxqHngCOIQEg/runs/0/artifacts/public/logs/live_backing.log [task 2017-11-06T00:12:27.233Z] 00:12:27 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Check the proper URL is loaded - [task 2017-11-06T00:12:27.235Z] 00:12:27 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Element should not be null, when checking visibility - [task 2017-11-06T00:12:27.236Z] 00:12:27 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Overlay is visible - [task 2017-11-06T00:12:27.238Z] 00:12:27 INFO - found chrome://browser/skin/preferences/preferences.css [task 2017-11-06T00:12:27.239Z] 00:12:27 INFO - found chrome://global/skin/in-content/common.css [task 2017-11-06T00:12:27.240Z] 00:12:27 INFO - found chrome://browser/skin/preferences/in-content/preferences.css [task 2017-11-06T00:12:27.242Z] 00:12:27 INFO - found chrome://browser/skin/preferences/in-content/dialog.css [task 2017-11-06T00:12:27.243Z] 00:12:27 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | All expectedStyleSheetURLs should have been found - [task 2017-11-06T00:12:27.244Z] 00:12:27 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The Settings dialog should be visible - [task 2017-11-06T00:12:27.245Z] 00:12:27 INFO - Buffered messages finished [task 2017-11-06T00:12:27.246Z] 00:12:27 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_siteData.js | Should list sites using quota usage or appcache - Got 1, expected 2 [task 2017-11-06T00:12:27.247Z] 00:12:27 INFO - Stack trace: [task 2017-11-06T00:12:27.249Z] 00:12:27 INFO - chrome://mochikit/content/browser-test.js:test_is:1010 [task 2017-11-06T00:12:27.250Z] 00:12:27 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js:null:155
Summary: Intermittent browser/components/preferences/in-content/tests/browser_siteData.js | Should list sites using quota usage or appcache - Got 1, expected 2 → Intermittent test-verify browser/components/preferences/in-content/tests/browser_siteData.js | Should list sites using quota usage or appcache - Got 1, expected 2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=158024307&repo=mozilla-inbound&lineNumber=16168 10:57:38 INFO - TEST-START | browser/components/preferences/in-content/tests/browser_siteData.js 10:57:50 INFO - GECKO(2695) | MEMORY STAT | vsize 4568MB | residentFast 516MB | heapAllocated 166MB 10:57:50 INFO - TEST-OK | browser/components/preferences/in-content/tests/browser_siteData.js | took 12718ms 10:57:50 INFO - checking window state 10:57:50 INFO - TEST-START | browser/components/preferences/in-content/tests/browser_siteData.js 10:57:54 INFO - TEST-INFO | started process screencapture 10:57:54 INFO - TEST-INFO | screencapture: exit 0 10:57:54 INFO - Buffered messages logged at 10:57:50 10:57:54 INFO - Entering test bound 10:57:54 INFO - Buffered messages logged at 10:57:51 10:57:54 INFO - Console message: Offline cache update done, URL=https://example.org/browser/browser/components/preferences/in-content/tests/offline/manifest.appcache 10:57:54 INFO - Buffered messages logged at 10:57:54 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Check the proper URL is loaded - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Element should not be null, when checking visibility - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Overlay is visible - 10:57:54 INFO - found chrome://browser/skin/preferences/preferences.css 10:57:54 INFO - found chrome://global/skin/in-content/common.css 10:57:54 INFO - found chrome://browser/skin/preferences/in-content/preferences.css 10:57:54 INFO - found chrome://browser/skin/preferences/in-content/dialog.css 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | All expectedStyleSheetURLs should have been found - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The Settings dialog should be visible - 10:57:54 INFO - Buffered messages finished 10:57:54 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_siteData.js | Should list sites using quota usage or appcache - Got 1, expected 2 10:57:54 INFO - Stack trace: 10:57:54 INFO - chrome://mochikit/content/browser-test.js:test_is:1269 10:57:54 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js:null:156 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should list site using appcache - 10:57:54 INFO - Not taking screenshot here: see the one that was previously logged 10:57:54 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_siteData.js | Should list site using quota usage - 10:57:54 INFO - Stack trace: 10:57:54 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js:null:162 10:57:54 INFO - Leaving test bound 10:57:54 INFO - Entering test bound 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should enable clear button after sites updated - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should enable settings button after sites updated - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should show the right total site data size - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should disable clear button while updating sites - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should disable settings button while updating sites - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should show the loading message while updating - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should enable clear button after sites updated - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should enable settings button after sites updated - 10:57:54 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should show the right total site data size - 10:57:54 INFO - Leaving test bound 10:57:54 INFO - Entering test bound 10:57:57 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The cache usage should not be 0 - 13312 > 0 - 10:57:57 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The quota usage should not be 0 - 49152 > 0 - 10:57:57 INFO - Not taking screenshot here: see the one that was previously logged 10:57:57 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_siteData.js | The total usage should not be 0 - 0 > 0 - JS frame :: chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js :: <TOP_LEVEL> :: line 238 10:57:57 INFO - Stack trace: 10:57:57 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js:null:238 10:57:58 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should not remove permission - 10:57:58 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The cache usage should not be 0 - 13312 > 0 - 10:57:58 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The quota usage should not be 0 - 49152 > 0 - 10:57:58 INFO - Not taking screenshot here: see the one that was previously logged 10:57:58 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_siteData.js | The total usage should not be 0 - 0 > 0 - JS frame :: chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js :: <TOP_LEVEL> :: line 257 10:57:58 INFO - Stack trace: 10:57:58 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js:null:257 10:57:59 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Should clear app cache - 10:57:59 INFO - Not taking screenshot here: see the one that was previously logged 10:57:59 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_siteData.js | Should remove permission - Got 1, expected 0 10:57:59 INFO - Stack trace: 10:57:59 INFO - chrome://mochikit/content/browser-test.js:test_is:1269 10:57:59 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js:null:278 10:57:59 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The cache usage should be removed - 10:57:59 INFO - Not taking screenshot here: see the one that was previously logged 10:57:59 INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_siteData.js | The quota usage should be removed - Got 49152, expected 0 10:57:59 INFO - Stack trace: 10:57:59 INFO - chrome://mochikit/content/browser-test.js:test_is:1269 10:57:59 INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_siteData.js:null:284 10:57:59 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The total usage should be removed - 10:57:59 INFO - Leaving test bound 10:57:59 INFO - Entering test bound 10:58:00 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Found the service worker registered for https://example.org/browser/browser/components/preferences/in-content/tests/service_worker_test.html - 10:58:01 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Cleared all service workers - 10:58:01 INFO - Leaving test bound 10:58:01 INFO - Entering test bound 10:58:03 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Found the service worker registered for https://example.org/browser/browser/components/preferences/in-content/tests/service_worker_test.html - 10:58:03 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Check the proper URL is loaded - 10:58:03 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Element should not be null, when checking visibility - 10:58:03 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Overlay is visible - 10:58:03 INFO - found chrome://browser/skin/preferences/preferences.css 10:58:03 INFO - found chrome://global/skin/in-content/common.css 10:58:03 INFO - found chrome://browser/skin/preferences/in-content/preferences.css 10:58:03 INFO - found chrome://browser/skin/preferences/in-content/dialog.css 10:58:03 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | All expectedStyleSheetURLs should have been found - 10:58:03 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | The Settings dialog should be visible - 10:58:04 INFO - TEST-PASS | browser/components/preferences/in-content/tests/browser_siteData.js | Cleared all service workers - 10:58:04 INFO - Leaving test bound 10:58:04 INFO - GECKO(2695) | MEMORY STAT | vsize 4584MB | residentFast 528MB | heapAllocated 141MB 10:58:04 INFO - TEST-OK | browser/components/preferences/in-content/tests/browser_siteData.js | took 13308ms 10:58:04 INFO - checking window state 10:58:06 INFO - GECKO(2695) | Completed ShutdownLeaks collections in process 2697 10:58:06 INFO - GECKO(2695) | Completed ShutdownLeaks collections in process 2698 10:58:06 INFO - GECKO(2695) | Completed ShutdownLeaks collections in process 2696 10:58:06 INFO - GECKO(2695) | Completed ShutdownLeaks collections in process 2699 10:58:06 INFO - GECKO(2695) | Completed ShutdownLeaks collections in process 2695 10:58:06 INFO - TEST-START | Shutdown 10:58:06 INFO - Browser Chrome Test Summary 10:58:06 INFO - Passed: 260 10:58:06 INFO - Failed: 6 10:58:06 INFO - Todo: 0 10:58:06 INFO - Mode: e10s 10:58:06 INFO - *** End BrowserChrome Test Results ***
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
I don't think our recent work caused this but we'd very much like this test not to be disabled, so I'll look into it.
Assignee: nobody → jhofmann
Status: REOPENED → ASSIGNED
Whiteboard: [storage-v2][triage]
:johannh, any updates on the fix? This still has a pretty large number of fails in the last 7 days (134) and 35 in the last two days. They are spread across all platforms. Do you still want this to not be disabled?
Flags: needinfo?(jhofmann)
I'm taking a look at it right now and will push a try run in a minute. I'll get a patch for disabling ready if I don't get any further to a solution by the end of today.
Flags: needinfo?(jhofmann)
So it seems that Services.qms.getUsage actually returns an error[0] quite frequently in these tests, and that causes SiteDataManager to skip collecting quota usage data[1]. It's not great that we don't report the error in SiteDataManager, but it's most important to figure out what's going wrong on the platform side here. Andrew, Jan, can you help me with that? [0] https://treeherder.mozilla.org/logviewer.html#?job_id=162413591&repo=try&lineNumber=13703 [1] https://searchfox.org/mozilla-central/rev/4234703a532006c5ef9ce09b4c487d88124526a0/browser/components/preferences/SiteDataManager.jsm#102
Flags: needinfo?(jvarga)
Flags: needinfo?(bugmail)
Attached patch Skipped testSplinter Review
Attachment #8952288 - Flags: review?(jmaher)
Comment on attachment 8952288 [details] [diff] [review] Skipped test Review of attachment 8952288 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay (this one is quite tricky), but can we please not disable the entire test and just skip the relevant task that is failing? I'll get a patch ready now. We should really find out what's failing this...
Attachment #8952288 - Flags: feedback-
Priority: P5 → P1
Comment on attachment 8952288 [details] [diff] [review] Skipped test happy to go with the approach of modifying the test case as Johann has created a patch for
Attachment #8952288 - Flags: review?(jmaher)
Comment on attachment 8952299 [details] Bug 1414751 - Disable frequently failing task in browser_siteData.js. https://reviewboard.mozilla.org/r/221542/#review227416
Attachment #8952299 - Flags: review?(nhnt11) → review+
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5708a33674f0 Disable frequently failing task in browser_siteData.js. r=nhnt11
Whiteboard: [storage-v2][triage][stockwell disable-recommended] → [storage-v2][triage][stockwell disabled]
Unassigning myself and moving this to Quota Manager since I believe the logs tell us that this is a DB issue.
Assignee: jhofmann → nobody
Status: ASSIGNED → NEW
Component: Preferences → DOM: Quota Manager
Product: Firefox → Core
Priority: P1 → --
Assignee: nobody → jvarga
Priority: -- → P2
Whiteboard: [storage-v2][triage][stockwell disabled] → [stockwell disabled]
Removing need-info and adding to DWS_NEXT
Flags: needinfo?(jvarga)
Flags: needinfo?(bugmail)
Whiteboard: [stockwell disabled] → [stockwell disabled]DWS_NEXT
Assignee: jvarga → nobody

Appcache support was removed.
The test needs to be changed to only used the quota manager, or removed completely.

Blocks: 1584984
Severity: normal → S3

Bulk closing intermittent bugs for DOM LWS that have not seen new instances since at least 5 months.

Status: NEW → RESOLVED
Closed: 8 years ago1 year ago
Resolution: --- → INCOMPLETE

Taking back the bulk change.

Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: INCOMPLETE → ---
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: leave-open
Status: NEW → RESOLVED
Closed: 1 year ago2 months ago
Resolution: --- → WORKSFORME
Whiteboard: [stockwell disabled]DWS_NEXT → [stockwell disabled]DWS_NEXT, dom-lws-bugdash-triage
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: