1414904 - Update robustcheckout to work with Mercurial 4.4

Status: RESOLVED FIXED

(Developer Services :: Mercurial: robustcheckout, enhancement)

Description

[Gregory Szorc [:gps]]

Let's get robustcheckout and its test suite working full with Mercurial 4.4. This blocks upgrading CI to 4.4.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: robustcheckout: Make robustcheckout compatible with Mercurial 4.4 (Bug 1414904)

Review commit: https://reviewboard.mozilla.org/r/206690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/206690/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8935822 [details]
robustcheckout: Make robustcheckout compatible with Mercurial 4.4 (Bug 1414904)

https://reviewboard.mozilla.org/r/206690/#review212462

This looks pretty good! Just a minor change to the version checking code.

Did you run the test harness with `./run-tests --all-hg-version -j8 hgext/robustcheckout`?

::: hgext/robustcheckout/__init__.py:225
(Diff revision 1)
>      # profiles on 4.3. When 4.4 is released, we'll need to opt in to sparse
>      # support. We /could/ silently fall back to non-sparse when not supported.
>      # However, given that sparse has performance implications, we want to fail
>      # fast if we can't satisfy the desired checkout request.
>      if sparseprofile:
> -        if util.versiontuple(n=2) != (4, 3):
> +        if util.versiontuple(n=2) < (4, 3):

We still want this to be an explicit allow list because the feature is still experimental in Mercurial and we don't want people accidentally using the extension with e.g. Mercurial 4.5 until we validate it works. So this should be something like:

`if util.versiontuple(n=2) not in ((4, 3), (4, 4)):`

Comment 3

[Connor Sheehan [:sheehan]]

Comment on attachment 8935822 [details]
robustcheckout: Make robustcheckout compatible with Mercurial 4.4 (Bug 1414904)

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/206690/diff/1-2/

Comment 4

[Connor Sheehan [:sheehan]]

Comment on attachment 8935822 [details]
robustcheckout: Make robustcheckout compatible with Mercurial 4.4 (Bug 1414904)

https://reviewboard.mozilla.org/r/206690/#review212462

Yes, the tests pass for all Mercurial versions. :)

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8935822 [details]
robustcheckout: Make robustcheckout compatible with Mercurial 4.4 (Bug 1414904)

https://reviewboard.mozilla.org/r/206690/#review212582

Nice! This unblocks us from rolling out Mercurial 4.4 in CI!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/4a274fa605f1
robustcheckout: Make robustcheckout compatible with Mercurial 4.4 r=gps