Closed Bug 1414930 Opened 4 years ago Closed 4 years ago

Remove the contentViewerEdit property from tabbrowser and browser bindings

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

57 Branch
enhancement

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: Gijs, Assigned: stevea1, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Both the tabbrowser and individual browser bindings have a `contentViewerEdit` property that's been there since hg@1 and seems to be unused. We should remove it.

This involves removing the property from:

https://dxr.mozilla.org/mozilla-central/rev/b5a3b8ef6902998507fc881b6d628b055457fe31/browser/base/content/tabbrowser.xml#5434-5436

and

https://dxr.mozilla.org/mozilla-central/rev/b5a3b8ef6902998507fc881b6d628b055457fe31/toolkit/content/widgets/browser.xml#487-489
Blocks: 1387013
Priority: -- → P3
Comment on attachment 8927596 [details]
Bug 1414930 - Remove the contentViewerEdit property from tabbrowser and browser bindings.

https://reviewboard.mozilla.org/r/198888/#review203916

Looks good, thanks!
Attachment #8927596 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e186446e8bf9
Remove the contentViewerEdit property from tabbrowser and browser bindings. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/e186446e8bf9
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Assignee: nobody → stevea1
You need to log in before you can comment on or make changes to this bug.