Remove the contentViewerEdit property from tabbrowser and browser bindings

RESOLVED FIXED in Firefox 58

Status

()

Firefox
Tabbed Browser
P3
normal
RESOLVED FIXED
13 days ago
7 days ago

People

(Reporter: Gijs, Assigned: Steve Armand, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

57 Branch
Firefox 58
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

13 days ago
Both the tabbrowser and individual browser bindings have a `contentViewerEdit` property that's been there since hg@1 and seems to be unused. We should remove it.

This involves removing the property from:

https://dxr.mozilla.org/mozilla-central/rev/b5a3b8ef6902998507fc881b6d628b055457fe31/browser/base/content/tabbrowser.xml#5434-5436

and

https://dxr.mozilla.org/mozilla-central/rev/b5a3b8ef6902998507fc881b6d628b055457fe31/toolkit/content/widgets/browser.xml#487-489

Updated

12 days ago
Blocks: 1387013
Priority: -- → P3
Comment hidden (mozreview-request)
(Reporter)

Comment 2

8 days ago
mozreview-review
Comment on attachment 8927596 [details]
Bug 1414930 - Remove the contentViewerEdit property from tabbrowser and browser bindings.

https://reviewboard.mozilla.org/r/198888/#review203916

Looks good, thanks!
Attachment #8927596 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 3

8 days ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e186446e8bf9
Remove the contentViewerEdit property from tabbrowser and browser bindings. r=Gijs

Comment 4

8 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e186446e8bf9
Status: NEW → RESOLVED
Last Resolved: 8 days ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Assignee: nobody → stevea1
You need to log in before you can comment on or make changes to this bug.