1414963 - Failure to push to mozreview.

Status: RESOLVED INVALID

(MozReview Graveyard :: Integration: Mercurial, defect)

Description

[Tom Prince [:tomprince]]

pushing to https://reviewboard-hg.mozilla.org/autoreview
searching for appropriate review repository
redirecting push to https://reviewboard-hg.mozilla.org/gecko
running checkstyle... failed (e.g. Java was not installed) - ignoring.
    To see full error output, run locally with: `./mach gradle checkstyle`
(adding commit id to 2 changesets)
transaction abort!
rollback completed
Traceback (most recent call last):
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/scmutil.py", line 154, in callcatch
    return func()
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/dispatch.py", line 303, in _runcatchfunc
    return _dispatch(req)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/dispatch.py", line 940, in _dispatch
    cmdpats, cmdoptions)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/dispatch.py", line 701, in runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/home/tomprince/.local/lib/python2.7/site-packages/hgext/pager.py", line 77, in pagecmd
    return orig(ui, options, cmd, cmdfunc)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/dispatch.py", line 948, in _runcommand
    return cmdfunc()
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/dispatch.py", line 937, in <lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/util.py", line 1183, in check
    return func(*args, **kwargs)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/util.py", line 1183, in check
    return func(*args, **kwargs)
  File "/home/tomprince/.mozbuild/version-control-tools/hgext/firefoxtree/__init__.py", line 505, in pushcommand
    return orig(ui, repo, dest=dest, **opts)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/util.py", line 1183, in check
    return func(*args, **kwargs)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/util.py", line 1183, in check
    return func(*args, **kwargs)
  File "/home/tomprince/.mozbuild/version-control-tools/hgext/reviewboard/client.py", line 231, in pushcommand
    return orig(ui, repo, *args, **kwargs)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/util.py", line 1183, in check
    return func(*args, **kwargs)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/util.py", line 1183, in check
    return func(*args, **kwargs)
  File "/home/tomprince/.local/lib/python2.7/site-packages/hgext3rd/evolve/__init__.py", line 788, in warnobserrors
    ret = orig(ui, repo, *args, **kwargs)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/util.py", line 1183, in check
    return func(*args, **kwargs)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/commands.py", line 4160, in push
    opargs=opargs)
  File "/home/tomprince/.mozbuild/version-control-tools/hgext/firefoxtree/__init__.py", line 308, in push
    **kwargs)
  File "/home/tomprince/.mozbuild/version-control-tools/hgext/reviewboard/client.py", line 316, in wrappedpush
    newbranch=False, **kwargs)
  File "/home/tomprince/.mozbuild/version-control-tools/hgext/reviewboard/client.py", line 375, in wrappedpush
    newbranch=newbranch, **kwargs)
  File "/home/tomprince/.local/lib/python2.7/site-packages/hgext3rd/evolve/__init__.py", line 811, in push
    return orig(repo, *args, **opts)
  File "/home/tomprince/.local/lib/python2.7/site-packages/mercurial/exchange.py", line 471, in push
    _pushdiscovery(pushop)
  File "/home/tomprince/.mozbuild/version-control-tools/hgext/reviewboard/client.py", line 504, in wrappedpushdiscovery
    backuptopic='addcommitid')
  File "/home/tomprince/.mozbuild/version-control-tools/pylib/mozhg/mozhg/rewrite.py", line 208, in replacechangesets
    raise util.Abort('we do not allow replacements to modify files')
Abort: we do not allow replacements to modify files
abort: we do not allow replacements to modify files

Comment 1

[Tom Prince [:tomprince]]

I get this with v-c-t rev bd44aec89c26

Comment 2

[Gregory Szorc [:gps]]

Could you please produce a Mercurial bundle of the 2 changesets that you are attempting to review and upload it here?

  $ hg bundle -r base::tip test.hg

Also, please let me know which repo this is for so I can apply the bundle.

Also, which version of Mercurial?

Comment 3

[Tom Prince [:tomprince]]

This is with mercurial 4.4.

I think it may have something to do with pushing something based on autoland. I was pushing with 'hg push review -r<revset evaluating to 8a352026bcf46c2a3afc462b8ea7de3600e44b5f>', but when I changed it to 'hg push review -c<revset evaluating to 8a352026bcf46c2a3afc462b8ea7de3600e44b5f>' it worked. My guess is that there was one merge on autoland that hadn't been pushed to review which something was choking on.

https://reviewboard.mozilla.org/r/196812/diff/1 is the review that ended up getting pushed.

Comment 4

[Gregory Szorc [:gps]]

The refactoring in bug 1413628 basically deferred the adding of "MozReview-Commit-ID" to commit messages. Now, first push of a changeset for review will *always* result in changeset rewriting.

I suspect this uncovered a latent bug in our changeset rewriting code. I was hoping to reproduce so we could squash that bug. Hopefully the next person that encounters it will be able to...

Comment 5

[Tom Prince [:tomprince]]

Running the following commands with an update autoland (i.e. just post merge) gives the same failure:

hg update autoland
touch test
hg add test
hg commit -m'Bug 1414963: Just a test'
hg push review -r.

And I bet s/-r/-c/ would "fix" it.

Comment 6

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.