Update FxScreenGraph navigator extension to use screen actions.

NEW
Unassigned

Status

()

Firefox for iOS
Build & Test
P2
normal
18 days ago
3 days ago

People

(Reporter: jhugman, Unassigned)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios10.3)

Details

(Reporter)

Description

18 days ago
This includes:

1. Adding extra properties to the FxUserState.
2. Rewriting navigator extension methods into the graph. This lets the graph document the app better, e.g. all of performBrowserAction can be moved into multiple actions.
3. Changing the call sites of openURL(urlString:) to and performBrowserAction() to better, more generic forms.
4. Removing any redundant states that no longer make sense – e.g. P_HomePanel_TopSites and PrivateHomePanelsScreen.
(Reporter)

Updated

17 days ago
Blocks: 1399250
tracking-fxios: ? → 10.1
Priority: -- → P2
Should this be closed now?
Flags: needinfo?(jhugman)
tracking-fxios: 10.1 → 10.3
(Reporter)

Comment 2

4 days ago
No. This should be on :npark and :irios's radar.
Flags: needinfo?(npark)
Flags: needinfo?(jhugman)
Flags: needinfo?(irios)
Lets keep it open. Now we are focused on fixing the broken tests and once that is done, we will improve the others according to the new FxScreenGraph and will update it accordingly (removing unnecessary code used previously, creating new states/actions and so). This bug could be as a reference for that work.

Thanks!
Flags: needinfo?(irios)
Flags: needinfo?(npark)
You need to log in before you can comment on or make changes to this bug.