1414986 - Update FxScreenGraph navigator extension to use screen actions.

Status: NEW

(Firefox for iOS :: Build & Test, enhancement, P2)

Description

[James Hugman [:jhugman] [@jhugman]]

This includes:

1. Adding extra properties to the FxUserState.
2. Rewriting navigator extension methods into the graph. This lets the graph document the app better, e.g. all of performBrowserAction can be moved into multiple actions.
3. Changing the call sites of openURL(urlString:) to and performBrowserAction() to better, more generic forms.
4. Removing any redundant states that no longer make sense – e.g. P_HomePanel_TopSites and PrivateHomePanelsScreen.

Comment 1

[Farhan Patel [:farhan]]

Should this be closed now?

Comment 2

[James Hugman [:jhugman] [@jhugman]]

No. This should be on :npark and :irios's radar.

Comment 3

[Isabel Rios[:isabel_rios]]

Lets keep it open. Now we are focused on fixing the broken tests and once that is done, we will improve the others according to the new FxScreenGraph and will update it accordingly (removing unnecessary code used previously, creating new states/actions and so). This bug could be as a reference for that work.

Thanks!