1415029 - extension-icon is blurred as compared to addons-notification-icon

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P3)

Description

[magicp]

Attachment: extension-icon-vs-addons-notification-icon.png

Steps to reproduce:
1. Open about:debugging
2. Load temporary Add-on "Permissions Example" (https://github.com/)mdn/webextensions-examples/tree/master/permissions
3. Click "Permissions Example" button on nav-bar
4. Click granted link of "The history permission is an optional permission that can be granted"

Actual Results:
extension-icon is blurred as compared to addons-notification-icon

Expected Results:
Use same icon with addons-notification-icon.
Or... Make a cool icon for WebExtensions, because it is strange if same icons are displayed.

Comment 1

[magicp]

(In reply to magicp from comment #0)
> 2. Load temporary Add-on "Permissions Example" (https://github.com/)mdn/webextensions-examples/tree/master/permissions
https://github.com/mdn/webextensions-examples/tree/master/permissions

Comment 2

[Matthew N. [:MattN]]

IIUC the favicon is the blurry one so this would be a webextension bug related to moz-extension pages

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: Bug 1415029 - Use better extension icon in identity block

Review commit: https://reviewboard.mozilla.org/r/203176/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/203176/

Comment 4

[Mark Striemer [:mstriemer]]

Attachment: icons-fixed.png

The icon that was being used is 64px with a slight gradient. This updates the icon to be the same as the one that appears beside it when the permission prompt opens.

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8932146 [details]
Bug 1415029 - Use better extension icon in identity block

https://reviewboard.mozilla.org/r/203176/#review208584

Delegate this to Johann, who's more familiar with the identity box.

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8932146 [details]
Bug 1415029 - Use better extension icon in identity block

https://reviewboard.mozilla.org/r/203176/#review208608

::: browser/base/content/browser.xul:860
(Diff revision 1)
>                           tooltiptext="&urlbar.emeNotificationAnchor.tooltip;"/>
>                    <image id="persistent-storage-notification-icon" class="notification-anchor-icon persistent-storage-icon" role="button"
>                           tooltiptext="&urlbar.persistentStorageNotificationAnchor.tooltip;"/>
>                  </box>
>                  <image id="connection-icon"/>
> -                <image id="extension-icon"/>
> +                <image id="extension-icon" class="install-icon"/>

Since we really only want to change the icon and not copy any other (future) properties of .install-icon, I'd prefer not to add this class, and instead add the #extension-icon selector to this rule:

https://searchfox.org/mozilla-central/rev/7a8c667bdd2a4a32746c9862356e199627c0896d/browser/themes/shared/notification-icons.inc.css#183

or just replace the icon path in identity-block.inc.css.

Comment 7

[Mark Striemer [:mstriemer]]

Comment on attachment 8932146 [details]
Bug 1415029 - Use better extension icon in identity block

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203176/diff/1-2/

Comment 8

[Johann Hofmann [:johannh]]

Comment on attachment 8932146 [details]
Bug 1415029 - Use better extension icon in identity block

https://reviewboard.mozilla.org/r/203176/#review208634

Looks good, thank you!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Autoland can't push this until all pending issues in MozReview are marked as resolved.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b247a3bf8989
Use better extension icon in identity block r=johannh

Comment 11

[Stefan Hindli [:stefan_hindli]]

Backed out 1 changesets (bug 1415029) for failing in browser/components/extensions/test/browser/test-oop-extensions/browser_ext_identity_indication.js r=backout on a CLOSED TREE

https://hg.mozilla.org/integration/autoland/rev/44dbee9aab054d6a974826c015b1378d7a9d1a0a
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=148048517

Comment 12

[Mark Striemer [:mstriemer]]

Comment on attachment 8932146 [details]
Bug 1415029 - Use better extension icon in identity block

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203176/diff/2-3/

Comment 13

[Mark Striemer [:mstriemer]]

Comment on attachment 8932146 [details]
Bug 1415029 - Use better extension icon in identity block

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/203176/diff/3-4/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ce2b2fa5bad
Use better extension icon in identity block r=johannh

Comment 15

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/6ce2b2fa5bad

Comment 16

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ce2b2fa5bad

Comment 17

[magicp]

Verified in the latest Nightly Build (20171130220131). Thanks!

Comment 18

[marius.santa]

Attachment: not blurred.PNG

I can reproduce this issue on Firefox 58.0a1 (20171106100122) under Wind 10 64-bit. 

This issue is verified as fixed on Firefox 58.0b8 (20171130160223), Firefox 59.0a1 (20171205100345) under Wind 10 64-bit and Mac OS X 10.13.