1415069 - Add a member to ChannelMediaResource to remember seekability of the channel

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

So it doesn't need to call mCacheStream.IsTransportSeekable() which needs to take the lock and might block the main thread.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1415069 - Add a member to ChannelMediaResource to remember seekability of the channel.

So it doesn't need to call mCacheStream.IsTransportSeekable() which needs to
take the lock and might block the main thread.

Review commit: https://reviewboard.mozilla.org/r/197982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197982/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8926740 [details]
Bug 1415069 - Add a member to ChannelMediaResource to remember seekability of the channel.

https://reviewboard.mozilla.org/r/197982/#review203164

::: dom/media/ChannelMediaResource.cpp:297
(Diff revision 1)
>    // This is important, we want to make sure all principals are updated before
>    // any consumer can see the new data.
>    UpdatePrincipal();
>  
>    mCacheStream.NotifyDataStarted(mLoadID, startOffset, seekable);
> +  mIsTransportSeekable = seekable;

Do we need to set the mIsTransportSeekable in ChannelMediaResource::CloneData() for the clone case?

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8926740 [details]
Bug 1415069 - Add a member to ChannelMediaResource to remember seekability of the channel.

https://reviewboard.mozilla.org/r/197982/#review203164

> Do we need to set the mIsTransportSeekable in ChannelMediaResource::CloneData() for the clone case?

Yes. Good catch!

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8926740 [details]
Bug 1415069 - Add a member to ChannelMediaResource to remember seekability of the channel.

https://reviewboard.mozilla.org/r/197982/#review203170

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8926740 [details]
Bug 1415069 - Add a member to ChannelMediaResource to remember seekability of the channel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197982/diff/1-2/

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the reviews!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f059a9dbd9d
Add a member to ChannelMediaResource to remember seekability of the channel. r=bechen,gerald

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2f059a9dbd9d