Add a member to ChannelMediaResource to remember seekability of the channel

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

So it doesn't need to call mCacheStream.IsTransportSeekable() which needs to take the lock and might block the main thread.
Assignee: nobody → jwwang
Blocks: 1369263
Priority: -- → P3
Attachment #8926740 - Flags: review?(bechen)
Comment on attachment 8926740 [details]
Bug 1415069 - Add a member to ChannelMediaResource to remember seekability of the channel.

https://reviewboard.mozilla.org/r/197982/#review203164

::: dom/media/ChannelMediaResource.cpp:297
(Diff revision 1)
>    // This is important, we want to make sure all principals are updated before
>    // any consumer can see the new data.
>    UpdatePrincipal();
>  
>    mCacheStream.NotifyDataStarted(mLoadID, startOffset, seekable);
> +  mIsTransportSeekable = seekable;

Do we need to set the mIsTransportSeekable in ChannelMediaResource::CloneData() for the clone case?
Attachment #8926740 - Flags: review?(bechen) → review+
Comment on attachment 8926740 [details]
Bug 1415069 - Add a member to ChannelMediaResource to remember seekability of the channel.

https://reviewboard.mozilla.org/r/197982/#review203164

> Do we need to set the mIsTransportSeekable in ChannelMediaResource::CloneData() for the clone case?

Yes. Good catch!
Attachment #8926740 - Flags: review?(gsquelart)
Comment on attachment 8926740 [details]
Bug 1415069 - Add a member to ChannelMediaResource to remember seekability of the channel.

https://reviewboard.mozilla.org/r/197982/#review203170
Attachment #8926740 - Flags: review?(gsquelart) → review+
Thanks for the reviews!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f059a9dbd9d
Add a member to ChannelMediaResource to remember seekability of the channel. r=bechen,gerald
https://hg.mozilla.org/mozilla-central/rev/2f059a9dbd9d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.