1415109 - Reader view should switch to a darker theme when using Night Mode

Status: RESOLVED INACTIVE

(Firefox for iOS :: Reader View, enhancement)

Description

[Simon Basca [:SimonB]]

Build: 10.0 (7617)
Device: iPad mini 4
iOS: 11.1

Steps to reproduce:
1. Go to bbc.com
2. Open the menu and turn "Night Mode" On
3. Open an article
4. Tap on the Reader View icon

Actual results:
- The content in Reader View is bright as the default theme is "Light".

Suggested solution:
- When using Night Mode we should use as default the "Dark" theme in Reader View.

Comment 1

[Erica Wright [:ewright]]

What is the desired behaviour here? The default style is only used the first time reader mode is used, then it will adhere to whatever the user sets. Are you suggesting overriding the user settings and adhering to the night mode setting instead?

Comment 2

[Justin D'Arcangelo [:justindarc]]

(In reply to Erica Wright [:ewright] from comment #1)
> What is the desired behaviour here? The default style is only used the first
> time reader mode is used, then it will adhere to whatever the user sets. Are
> you suggesting overriding the user settings and adhering to the night mode
> setting instead?

I think what he's suggesting is that the color scheme should be inverted in Reader Mode when Night Mode is also turned on. If I'm reading an article on say Wikipedia with Night Mode turned on, I get white text on a black background. But, if I go into Reader Mode, the color scheme uses black text on a white background. I believe this is because we don't seem to inject our Night Mode JS/CSS into the webview that Reader Mode uses.

Comment 3

[Erica Wright [:ewright]]

So if the user were to set their style to sepia in the past, then be visiting a page in night mode, the proposal is that the when they switch to reader mode it automatically forces dark styling to be on. If that were to be implemented it almost renders the color picking ability in reader mode obsolete. The user would get dark in night mode, and get light or sepia in default mode.

Comment 4

[Justin D'Arcangelo [:justindarc]]

(In reply to Erica Wright [:ewright] from comment #3)
> So if the user were to set their style to sepia in the past, then be
> visiting a page in night mode, the proposal is that the when they switch to
> reader mode it automatically forces dark styling to be on. If that were to
> be implemented it almost renders the color picking ability in reader mode
> obsolete. The user would get dark in night mode, and get light or sepia in
> default mode.

Oh right, I forgot Reader Mode had those 3 settings. Yeah, nevermind then. I'm not sure how we could deal with this.

Comment 5

[Farhan Patel [:farhan]]

Bug has been migrated to Github. Closing.
To add additional comments please find the bug in Github.

https://github.com/mozilla-mobile/firefox-ios/issues