Closed Bug 1415114 Opened 8 years ago Closed 6 years ago

Remove duplication of tests between WPT and mochitest plain

Categories

(Core :: Graphics: Canvas2D, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: automatedtester, Assigned: automatedtester)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(3 files)

There are a number of tests that are duplicated between WPT and mochitest. Since WPT means we know that we have conformance with other browsers.
Priority: -- → P5
Milan, I was looking at what is duplicated and have come up with this patch. I am not expecting this to land "soon" but what would still be required from your part to make sure that we can land these changes in the future?
Flags: needinfo?(milan)
I'm going to let :kats look deeper into and understand the issue; from my point of view, if the frequency and hardware coverage is the same between WPT and mochitests, only having these run "once", I imagine as a part of WPT would be fine. However, if, for some reason, we only run WPT tests on a subset of hardware, or with significantly lower frequency, we may need to leave them in there in two places.
Flags: needinfo?(milan) → needinfo?(bugmail)
From a quick search through the taskcluster configs it looks like we run mochitests but not WPT on ASAN builds (linux, windows) as well as android. ASAN coverage is probably not hugely important, but losing coverage on Android is not great. Are there any plans to run WPT on Android?
Flags: needinfo?(bugmail)
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #4) > From a quick search through the taskcluster configs it looks like we run > mochitests but not WPT on ASAN builds (linux, windows) as well as android. > ASAN coverage is probably not hugely important, but losing coverage on > Android is not great. Are there any plans to run WPT on Android? We do plan to get it working on Android. I am trying to see if I moved a group of tests what would be the pain points. Your answer above has helped me to understand this.
:jrmuizel While I was doing this work I have noticed that we have a number of tests that are no longer in the specification (https://www.w3.org/TR/2dcontext/#dom-context-2d-globalcompositeoperation sorry if this is the wrong spec, I couldnt find a better one around) Should I raise a bug for this?
Flags: needinfo?(jmuizelaar)
(In reply to David Burns :automatedtester from comment #6) > Should I raise a bug for this? Yes
Flags: needinfo?(jmuizelaar)
Whiteboard: [gfx-noted]

These tests are already covered by Web Platform Tests which are run against
other browsers guaranteeing interop where mochitest does not.

When looking at the spec[1] for this it looks like WPT would benefit from porting over mochitests for the compositing

[1] https://drafts.fxtf.org/compositing-1/#canvascompositingandblending

These tests are already covered by Web Platform Tests which are run against
other browsers guaranteeing interop where mochitest does not.

Assignee: nobody → dburns
Pushed by dburns@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00fa39c78680 Remove 2D Canvas Mochitests in favour of Web Platform Tests r=jrmuizel
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: