Closed
Bug 1415115
Opened 9 years ago
Closed 8 years ago
PERMA-FAIL | accessible/tests/mochitest/events/docload/test_docload_root.html | Test timed out.
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
INVALID
People
(Reporter: xeonchen, Assigned: yzen)
References
Details
Attachments
(2 files)
|
1.73 MB,
text/x-log
|
Details | |
|
2.07 KB,
patch
|
surkov
:
review+
|
Details | Diff | Splinter Review |
This ONLY happens after applying patches of bug 1373708, but it didn't seem to happen several weeks ago, so I'm tracing regression range.
[1] https://treeherder.mozilla.org/logviewer.html#?job_id=142668716&repo=try&lineNumber=2620
| Reporter | ||
Comment 1•9 years ago
|
||
program hangs after line #9896
> INFO Invoke the 'close dialog' test { scenario #0: expected 'focus' event; }
Hi Yura, I saw your patch of bug 638313, do you have any idea if there's any assumption in the code that may hang hang if some resources are opened asynchronously?
In this case I can see two files:
- omni.ja!/chrome/toolkit/res/loading-image.png
- omni.ja!/chrome/toolkit/res/broken-image.png
are async-opened before #9896 and loaded after.
Flags: needinfo?(yzenevich)
| Reporter | ||
Comment 2•9 years ago
|
||
By the way, this happens after bug 638313 is landed.
| Assignee | ||
Updated•9 years ago
|
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Component: Accessibility → Disability Access APIs
Flags: needinfo?(yzenevich)
Product: Composer → Core
Version: other → unspecified
| Assignee | ||
Comment 3•9 years ago
|
||
I want to see if explicit focus on window helps things on linux.
Attachment #8925985 -
Flags: review?(surkov.alexander)
Comment 4•9 years ago
|
||
Comment on attachment 8925985 [details] [diff] [review]
1415115.patch
Review of attachment 8925985 [details] [diff] [review]:
-----------------------------------------------------------------
I don't have any problems with the approach, I guess it should do a trick, but you could have enabled logging to see if the focus event is indeed not fired or, if it's fired, then where it goes to. At least you could have a better understanding what happens here.
Attachment #8925985 -
Flags: review?(surkov.alexander) → review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35a375648ee0
forcing test window focus on dialog close. r=surkov
| Assignee | ||
Comment 6•9 years ago
|
||
Hi Gary, adding 'leave-open' to make sure it fixes your issue. Could you try running the test on your side with the rebased vesrion once it lands on nightly?
Flags: needinfo?(xeonchen)
Keywords: leave-open
| Reporter | ||
Comment 7•9 years ago
|
||
Unfortunately, it doesn't fix this issue :(
[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4e7ac17b308bf06be9a915439b29f7ad7321bd3&selectedJob=142992408
Flags: needinfo?(xeonchen)
Comment 8•9 years ago
|
||
| bugherder | ||
| Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Gary Chen [:xeonchen] (needinfo plz) from comment #7)
> Unfortunately, it doesn't fix this issue :(
>
> [1]
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=f4e7ac17b308bf06be9a915439b29f7ad7321bd3&selectedJob=1
> 42992408
Alex, do you think we can fire a reorder event for cases like this - when child dialog window is closed?
Flags: needinfo?(surkov.alexander)
| Reporter | ||
Comment 10•9 years ago
|
||
Don't know if this helps, but I found that removing all tests except test_docload_root.html will make it green.
Then I add them back one by one[1-5], only |test_docload_busy.html| or |test_docload_embedded.html| break the test.
[1] aria https://treeherder.mozilla.org/#/jobs?repo=try&revision=8615ef1ae5aa5402a47ea7df100b49f58500665e
[2] busy https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0a5d2a2ea049c515d6ddd2531dd417ca3b47ca0
[3] embedded https://treeherder.mozilla.org/#/jobs?repo=try&revision=b4ca128635fb26e34a52bc9917659b0a430c544f
[4] iframe https://treeherder.mozilla.org/#/jobs?repo=try&revision=595103f0b7da51145d7826df1167964f0567a497
[5] shutdown https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3637784f620cbcbfc4811141a11dd7d07d8050d
Comment 11•9 years ago
|
||
(In reply to Yura Zenevich [:yzen] from comment #9)
> (In reply to Gary Chen [:xeonchen] (needinfo plz) from comment #7)
> > Unfortunately, it doesn't fix this issue :(
> >
> > [1]
> > https://treeherder.mozilla.org/#/
> > jobs?repo=try&revision=f4e7ac17b308bf06be9a915439b29f7ad7321bd3&selectedJob=1
> > 42992408
>
> Alex, do you think we can fire a reorder event for cases like this - when
> child dialog window is closed?
reorder event on application accessible or? do you know what happens with the focus? it has to go somewhere, no?
| Assignee | ||
Comment 13•8 years ago
|
||
Hi Gary, I'm trying to run the tests on a local ubuntu machine with patches from bug 1373708 applied and I can't seem to get any failures (even when running with --verify flag). Do I have to do anything specific/additional to see permafail locally?
Flags: needinfo?(xeonchen)
| Reporter | ||
Comment 14•8 years ago
|
||
(In reply to Yura Zenevich [:yzen] from comment #13)
> Hi Gary, I'm trying to run the tests on a local ubuntu machine with patches
> from bug 1373708 applied and I can't seem to get any failures (even when
> running with --verify flag). Do I have to do anything specific/additional to
> see permafail locally?
I can't reproduce this on my platform, either.
It's somehow like a treeherder-only issue.
But if you want to reproduce locally, you have to run packaged version of gecko by:
$ mach package
$ mach mochitest --appname dist <other arguments>
Flags: needinfo?(xeonchen)
| Reporter | ||
Comment 15•8 years ago
|
||
It's green on yesterday's m-c!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa043f9cf4d1128ad8f6ff73009a0c76b6a0bb78
So let's close this.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
| Assignee | ||
Comment 16•8 years ago
|
||
(In reply to Gary Chen [:xeonchen] (needinfo plz) from comment #15)
> It's green on yesterday's m-c!
>
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=aa043f9cf4d1128ad8f6ff73009a0c76b6a0bb78
>
> So let's close this.
hmm, fascinating, :)
Flags: needinfo?(yzenevich)
Comment 17•8 years ago
|
||
(In reply to Yura Zenevich [:yzen] from comment #16)
> (In reply to Gary Chen [:xeonchen] (needinfo plz) from comment #15)
> > It's green on yesterday's m-c!
> >
> > https://treeherder.mozilla.org/#/
> > jobs?repo=try&revision=aa043f9cf4d1128ad8f6ff73009a0c76b6a0bb78
> >
> > So let's close this.
>
> hmm, fascinating, :)
yeah, a bit scary though
Comment 18•8 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•