1415149 - Simplify nsCSSFrameConstructor::GetRangeInsertionPoint

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

It's too complex.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #0)
> It's too complex.

Unnecessarily, I mean :)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1415149: Simplify nsCSSFrameConstructor::GetRangeInsertionPoint.

Review commit: https://reviewboard.mozilla.org/r/197122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197122/

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 8925907 [details]
Bug 1415149: Simplify nsCSSFrameConstructor::GetRangeInsertionPoint.

https://reviewboard.mozilla.org/r/197122/#review202376

Looks fine to me, but this code involves icky XBL stuff so please ask bz for review instead.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Sure thing, thanks mats!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8925907 [details]
Bug 1415149: Simplify nsCSSFrameConstructor::GetRangeInsertionPoint.

https://reviewboard.mozilla.org/r/197122/#review202712

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d8585ec74b3
Simplify nsCSSFrameConstructor::GetRangeInsertionPoint. r=bz

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2d8585ec74b3