Closed Bug 1415149 Opened 2 years ago Closed 2 years ago

Simplify nsCSSFrameConstructor::GetRangeInsertionPoint

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

It's too complex.
(In reply to Emilio Cobos Álvarez [:emilio] from comment #0)
> It's too complex.

Unnecessarily, I mean :)
Comment on attachment 8925907 [details]
Bug 1415149: Simplify nsCSSFrameConstructor::GetRangeInsertionPoint.

https://reviewboard.mozilla.org/r/197122/#review202376

Looks fine to me, but this code involves icky XBL stuff so please ask bz for review instead.
Attachment #8925907 - Flags: review?(mats)
Sure thing, thanks mats!
Attachment #8925907 - Flags: review?(bzbarsky)
Comment on attachment 8925907 [details]
Bug 1415149: Simplify nsCSSFrameConstructor::GetRangeInsertionPoint.

https://reviewboard.mozilla.org/r/197122/#review202712
Attachment #8925907 - Flags: review?(bzbarsky) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2d8585ec74b3
Simplify nsCSSFrameConstructor::GetRangeInsertionPoint. r=bz
https://hg.mozilla.org/mozilla-central/rev/2d8585ec74b3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.