1415163 - mozinstall fails with InstallError on test machines with Windows code coverage build

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: log_raw.tar.xz

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d42fe1917bf50913621793a96762fb7a98ff361a

Any idea what could be the cause of the failure? Could you help me debug it?

Comment 1

[Andrew Halberstadt [:ahal]]

Mozinstall is trying to be too clever for its own good in the exception handling and it's clobbering the original exception type. Try adding a 'raise' here to prevent that:
https://dxr.mozilla.org/mozilla-central/source/testing/mozbase/mozinstall/mozinstall/mozinstall.py#138

That should at least make the error a bit more useful. Is it possible the zip file it's trying to extract is malformed or empty or something?

Comment 2

[Marco Castelluccio [:marco]]

I've completely removed the exception handling part, the exception is a "MemoryError": https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b3f2d42b0fc453d8d7a91944831458753198a21&selectedJob=142824908.

Comment 3

[Marco Castelluccio [:marco]]

I guess I will have to switch to win64 and I will have to wait for bug 1413630.

Comment 4

[Marco Castelluccio [:marco]]

Or maybe we can replace https://dxr.mozilla.org/mozilla-central/rev/2535bad09d720e71a982f3f70dd6925f66ab8ec7/testing/mozbase/mozfile/mozfile/mozfile.py#73 to avoid reading the contents of the zip entry in memory and extract it directly.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's exactly what we work on bug 1404887. So this issue might be fixed by the other bug?

Comment 6

[Marco Castelluccio [:marco]]

Tested on try, this is indeed fixed by bug 1404887.