Closed Bug 1415167 Opened 8 years ago Closed 8 years ago

Update Network Monitor to use prop-types and react-dom-factories

Categories

(DevTools :: Netmonitor, enhancement, P2)

Product:
DevTools
Component:
Netmonitor
Type:
enhancement

Tracking

(firefox59 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 59
Tracking Flags:
Tracking Status
firefox59 --- fixed

People

(Reporter: miker, Assigned: miker)

References

Details

Attachments

(1 file)

Bug 1415167 - Network Monitor to use prop-types and react-dom-factories
59 bytes, text/x-review-board-request
Honza
: review+
Details
There are a number of reasons for this: 1. We need to have the modules available for code from devtools-core, which uses them. 2. It begins the process of getting rid of React deprecation warnings. 3. It prepares us to upgrade to React 16. Versioning info from devtools-core github repo: "prop-types": "^15.6.0" "react-dom-factories": "^1.0.2"
Comment on attachment 8926348 [details] Bug 1415167 - Network Monitor to use prop-types and react-dom-factories https://reviewboard.mozilla.org/r/197616/#review203318 Thanks for the patch Mike! A few comments/questions: 1) Try has a few failures, are these related? 2) I am not seeing `react-dom-factories` and `react-prop-types` in vendor directory 3) Why `DOM` has been renamed to `dom`, is there any concensus on the naming here? 4) I am still seeing some React warnings in the browser console, but this patch isn't supposed to fix them all, correct? Honza
Attachment #8926348 - Flags: review?(odvarko)
It looks like this patch also depends on decision in https://github.com/devtools-html/rfcs/issues/26 Honza
(In reply to Jan Honza Odvarko [:Honza] from comment #2) > Comment on attachment 8926348 [details] > Bug 1415167 - Network Monitor to use prop-types and react-dom-factories > > https://reviewboard.mozilla.org/r/197616/#review203318 > > Thanks for the patch Mike! > > A few comments/questions: > 1) Try has a few failures, are these related? No, they are from an earlier platform bug but I won't land anything until there is a green try. > 2) I am not seeing `react-dom-factories` and `react-prop-types` in vendor > directory Hence the dependency on bug 1413860 > 3) Why `DOM` has been renamed to `dom`, is there any concensus on the naming > here? The AST transformer has to choose either one or the other so I decided to choose the most common (dom). Almost everywhere in the codebase we use dom (it was usually imported as `const { DOM: dom } = require(...)`). > 4) I am still seeing some React warnings in the browser console, but this > patch isn't supposed to fix them all, correct? > Honza No, there will still be some warnings from shared components but they will all be fixed.
(In reply to Jan Honza Odvarko [:Honza] from comment #3) > It looks like this patch also depends on decision in > https://github.com/devtools-html/rfcs/issues/26 > > Honza No, we are not removing createFactory.
Comment on attachment 8926348 [details] Bug 1415167 - Network Monitor to use prop-types and react-dom-factories https://reviewboard.mozilla.org/r/197616/#review204094 Thanks, r+ assuming try is green. Honza
Attachment #8926348 - Flags: review?(odvarko) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 7fda43b6b55d -d 22ab4a21cb67: rebasing 433812:7fda43b6b55d "Bug 1415167 - Network Monitor to use prop-types and react-dom-factories r=Honza" (tip) merging devtools/client/netmonitor/src/components/PropertiesView.js merging devtools/client/netmonitor/src/components/RequestListColumnFile.js merging devtools/client/netmonitor/src/components/RequestListContent.js merging devtools/client/netmonitor/src/components/RequestListItem.js merging devtools/client/netmonitor/src/components/ResponsePanel.js merging devtools/client/netmonitor/src/components/TabboxPanel.js merging devtools/client/netmonitor/src/components/Toolbar.js warning: conflicts while merging devtools/client/netmonitor/src/components/RequestListColumnFile.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 9e6f9f9a3959 -d 22ab4a21cb67: rebasing 433813:9e6f9f9a3959 "Bug 1415167 - Network Monitor to use prop-types and react-dom-factories r=Honza" (tip) merging devtools/client/netmonitor/src/components/RequestListColumnFile.js merging devtools/client/netmonitor/src/components/RequestListContent.js merging devtools/client/netmonitor/src/components/RequestListItem.js merging devtools/client/netmonitor/src/components/ResponsePanel.js merging devtools/client/netmonitor/src/components/TabboxPanel.js merging devtools/client/netmonitor/src/components/Toolbar.js warning: conflicts while merging devtools/client/netmonitor/src/components/RequestListColumnFile.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 98e66d4aa0ea -d db021650476b: rebasing 433855:98e66d4aa0ea "Bug 1415167 - Network Monitor to use prop-types and react-dom-factories r=Honza" (tip) merging devtools/client/netmonitor/src/components/RequestListColumnFile.js merging devtools/client/netmonitor/src/components/RequestListContent.js merging devtools/client/netmonitor/src/components/RequestListItem.js merging devtools/client/netmonitor/src/components/ResponsePanel.js merging devtools/client/netmonitor/src/components/TabboxPanel.js merging devtools/client/netmonitor/src/components/Toolbar.js warning: conflicts while merging devtools/client/netmonitor/src/components/RequestListColumnFile.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 2b8b2b138c11 -d b414fcb0ff43: rebasing 433876:2b8b2b138c11 "Bug 1415167 - Network Monitor to use prop-types and react-dom-factories r=Honza" (tip) merging devtools/client/netmonitor/src/components/RequestListColumnFile.js merging devtools/client/netmonitor/src/components/RequestListContent.js merging devtools/client/netmonitor/src/components/RequestListItem.js merging devtools/client/netmonitor/src/components/ResponsePanel.js merging devtools/client/netmonitor/src/components/TabboxPanel.js merging devtools/client/netmonitor/src/components/Toolbar.js warning: conflicts while merging devtools/client/netmonitor/src/components/RequestListColumnFile.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0c3287dc520 Network Monitor to use prop-types and react-dom-factories r=Honza
https://hg.mozilla.org/mozilla-central/rev/a0c3287dc520
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: