Closed Bug 1415172 Opened 2 years ago Closed 2 years ago

Set up watersheds to move users to Firefox 57

Categories

(Release Engineering :: Release Automation: Other, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(1 file)

Expected results are at: https://docs.google.com/spreadsheets/d/17u3x092rGPB0rTwManlJ3nN2WdNwy2DgXifW8RwtpFA/edit#gid=0

Jordan added rules in Balrog earlier today. Matching rules are detailed in the spreadsheet above.

Now, UV tests should be updated and we should run Ben's new update tests.
I'm adding back the 56 watershed to win{32,64}. It got removed by https://hg.mozilla.org/build/tools/rev/f7695bb9f4c0 . The patch is simpler because it turns out the UV test takes the last defined `to_*` vars: 
1. Vars are declared here: https://dxr.mozilla.org/build-central/rev/51827305b856dab885ad5c8038fd62d682a4978a/tools/release/updates/verify.sh#18
2. and affected here https://dxr.mozilla.org/build-central/rev/51827305b856dab885ad5c8038fd62d682a4978a/tools/release/updates/verify.sh#104. If the value is missing, then it keeps the old value defined.
Comment on attachment 8925924 [details]
Bug 1415172 - Put back 56.0 watersheds for windows

https://reviewboard.mozilla.org/r/197142/#review202260
Attachment #8925924 - Flags: review?(bugspam.Callek) → review+
Comment on attachment 8925924 [details]
Bug 1415172 - Put back 56.0 watersheds for windows

I backed this out because it's not compatible with the update verify chunking script, which considers "to_build_id" a shared key amongst all rows of the config (https://hg.mozilla.org/build/tools/file/tip/lib/python/release/updates/verify.py).

I also don't think there's a reason to test watersheds in update verify -- we already know that <56.0 builds can apply 56.0 successfully.
update here:

thanks to ben, johan and others, we now have all green update verify tasks for 57!
next up: callek is currently porting release-localtest rules over to release-cdntest so we have coverage there.
(In reply to Jordan Lund (:jlund) from comment #7)
> next up: callek is currently porting release-localtest rules over to
> release-cdntest so we have coverage there.

And as of now, I believe release-cdntest is correct, verified with ben's current update sanity script.
57 shipped. rules in place
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.