1415205 - Add add mutate() to nsIURI

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

Part of making nsIURI implementations immutable, we need to remove the setters.

To achieve this, we will first add nsIURI.mutate() that returns a mutator.
The mutator will have all the appropriate setters (while not implementing nsIURI, to prevent it from being passed to others).
Calling finalize() on the mutator will return a new (immutable) nsIURI.

After this pattern is adopted we can remove the setters from nsIURI (separate bug)

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1415205 - Add nsIURIMutator interface and nsIURI.mutate()

Review commit: https://reviewboard.mozilla.org/r/200744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200744/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1415205 - Add nsIURIMutator impls for all objects implementing nsIURI

This also changes URIUtils.cpp:DeserializeURI() to use the mutator to instantiate new URIs, instead of using their default constructor.

Review commit: https://reviewboard.mozilla.org/r/200746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200746/

Comment 3

[Code Review Bot [:reviewbot]]

Comment on attachment 8929418 [details]
Bug 1415205 - Add nsIURIMutator impls for all objects implementing nsIURI

https://reviewboard.mozilla.org/r/200746/#review205960


C/C++ static analysis found 1 defect in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`


::: ipc/glue/URIUtils.cpp:128
(Diff revision 1)
>      MOZ_ASSERT(false, "Deserialize failed!");
>      return nullptr;
>    }
>  
> -  nsCOMPtr<nsIURI> uri = do_QueryInterface(serializable);
> +  nsCOMPtr<nsIURI> uri;
> +  rv = mutator->Finalize(getter_AddRefs(uri));

Warning: Value stored to 'rv' is never read [clang-tidy: clang-analyzer-deadcode.DeadStores]

Comment 4

[Daniel Stenberg [:bagder]]

Comment on attachment 8929417 [details]
Bug 1415205 - Add nsIURIMutator interface and nsIURI.mutate()

https://reviewboard.mozilla.org/r/200744/#review206016

Comment 5

[Daniel Stenberg [:bagder]]

Comment on attachment 8929418 [details]
Bug 1415205 - Add nsIURIMutator impls for all objects implementing nsIURI

https://reviewboard.mozilla.org/r/200746/#review206332

LGTM!

::: ipc/glue/URIUtils.cpp:128
(Diff revision 1)
>      MOZ_ASSERT(false, "Deserialize failed!");
>      return nullptr;
>    }
>  
> -  nsCOMPtr<nsIURI> uri = do_QueryInterface(serializable);
> +  nsCOMPtr<nsIURI> uri;
> +  rv = mutator->Finalize(getter_AddRefs(uri));

clang warns about this 'rv' is not used!

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8929417 [details]
Bug 1415205 - Add nsIURIMutator interface and nsIURI.mutate()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200744/diff/1-2/

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8929418 [details]
Bug 1415205 - Add nsIURIMutator impls for all objects implementing nsIURI

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200746/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6339ec0511b
Add nsIURIMutator interface and nsIURI.mutate() r=bagder
https://hg.mozilla.org/integration/autoland/rev/306f999b79a5
Add nsIURIMutator impls for all objects implementing nsIURI r=bagder

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a6339ec0511b
https://hg.mozilla.org/mozilla-central/rev/306f999b79a5