Closed Bug 1415235 Opened 2 years ago Closed 2 years ago

Rename adjustTabstrip to something more meaningful

Categories

(Firefox :: Tabbed Browser, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

adjustTabstrip is all about updating the tab close buttons. Not sure if it was originally supposed to do more.
Comment on attachment 8926014 [details]
Bug 1415235 - Rename adjustTabstrip to _updateCloseButtons.

https://reviewboard.mozilla.org/r/197250/#review202532

adjustTabstrip is referenced in http://searchfox.org/mozilla-central/source/devtools/client/responsive.html/docs/browser-swap.md#63

Do you know what the purpose of this file is, and if we need to update it?
Attachment #8926014 - Flags: review?(florian) → review+
(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> Comment on attachment 8926014 [details]
> Bug 1415235 - Rename adjustTabstrip to _updateCloseButtons.
> 
> https://reviewboard.mozilla.org/r/197250/#review202532
> 
> adjustTabstrip is referenced in
> http://searchfox.org/mozilla-central/source/devtools/client/responsive.html/
> docs/browser-swap.md#63
> 
> Do you know what the purpose of this file is, and if we need to update it?

It's "low level" documentation (http://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/devtools/client/responsive.html/browser/swap.js#25-26) that I don't think should be there, since it seems neither useful nor can we be expected to keep this updated.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c335c6da2ba1
Rename adjustTabstrip to _updateCloseButtons. r=florian
(In reply to Dão Gottwald [::dao] from comment #3)
> (In reply to Florian Quèze [:florian] [:flo] from comment #2)
> > Comment on attachment 8926014 [details]
> > Bug 1415235 - Rename adjustTabstrip to _updateCloseButtons.
> > 
> > https://reviewboard.mozilla.org/r/197250/#review202532
> > 
> > adjustTabstrip is referenced in
> > http://searchfox.org/mozilla-central/source/devtools/client/responsive.html/
> > docs/browser-swap.md#63
> > 
> > Do you know what the purpose of this file is, and if we need to update it?
> 
> It's "low level" documentation
> (http://searchfox.org/mozilla-central/rev/
> ed212c79cfe86357e9a5740082b9364e7f6e526f/devtools/client/responsive.html/
> browser/swap.js#25-26) that I don't think should be there, since it seems
> neither useful nor can we be expected to keep this updated.

Filed bug 1415502 on removing this.
https://hg.mozilla.org/mozilla-central/rev/c335c6da2ba1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
You need to log in before you can comment on or make changes to this bug.