1415235 - Rename adjustTabstrip to something more meaningful

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P1)

Description

[Dão Gottwald [:dao]]

adjustTabstrip is all about updating the tab close buttons. Not sure if it was originally supposed to do more.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1415235 - Rename adjustTabstrip to _updateCloseButtons.

Review commit: https://reviewboard.mozilla.org/r/197250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197250/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8926014 [details]
Bug 1415235 - Rename adjustTabstrip to _updateCloseButtons.

https://reviewboard.mozilla.org/r/197250/#review202532

adjustTabstrip is referenced in http://searchfox.org/mozilla-central/source/devtools/client/responsive.html/docs/browser-swap.md#63

Do you know what the purpose of this file is, and if we need to update it?

Comment 3

[Dão Gottwald [:dao]]

(In reply to Florian Quèze [:florian] [:flo] from comment #2)
> Comment on attachment 8926014 [details]
> Bug 1415235 - Rename adjustTabstrip to _updateCloseButtons.
> 
> https://reviewboard.mozilla.org/r/197250/#review202532
> 
> adjustTabstrip is referenced in
> http://searchfox.org/mozilla-central/source/devtools/client/responsive.html/
> docs/browser-swap.md#63
> 
> Do you know what the purpose of this file is, and if we need to update it?

It's "low level" documentation (http://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/devtools/client/responsive.html/browser/swap.js#25-26) that I don't think should be there, since it seems neither useful nor can we be expected to keep this updated.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c335c6da2ba1
Rename adjustTabstrip to _updateCloseButtons. r=florian

Comment 5

[Dão Gottwald [:dao]]

(In reply to Dão Gottwald [::dao] from comment #3)
> (In reply to Florian Quèze [:florian] [:flo] from comment #2)
> > Comment on attachment 8926014 [details]
> > Bug 1415235 - Rename adjustTabstrip to _updateCloseButtons.
> > 
> > https://reviewboard.mozilla.org/r/197250/#review202532
> > 
> > adjustTabstrip is referenced in
> > http://searchfox.org/mozilla-central/source/devtools/client/responsive.html/
> > docs/browser-swap.md#63
> > 
> > Do you know what the purpose of this file is, and if we need to update it?
> 
> It's "low level" documentation
> (http://searchfox.org/mozilla-central/rev/
> ed212c79cfe86357e9a5740082b9364e7f6e526f/devtools/client/responsive.html/
> browser/swap.js#25-26) that I don't think should be there, since it seems
> neither useful nor can we be expected to keep this updated.

Filed bug 1415502 on removing this.

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c335c6da2ba1