Closed
Bug 1415249
Opened 7 years ago
Closed 7 years ago
Remove unused variables introduced during EUI 64 (MAC-based) IPv6 candidate gathering
Categories
(Core :: WebRTC: Networking, enhancement, P2)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: mjf, Assigned: mjf)
References
Details
Attachments
(1 file)
Bug 1408218 introduced two new variables (contains_mac_based_ipv6 and contains_teredo_ipv6) that are set but never used. They should be removed.
|
Assignee | |
Updated•7 years ago
|
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926037 [details] Bug 1415249 - remove unused variables introduced in Bug 1408218. https://reviewboard.mozilla.org/r/197264/#review202412 Lgtm and thanks for the fix
Attachment #8926037 -
Flags: review?(drno) → review+
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926037 [details] Bug 1415249 - remove unused variables introduced in Bug 1408218. https://reviewboard.mozilla.org/r/197264/#review202416 C/C++ static analysis found 0 defects in this patch. You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`
Pushed by mfroman@nostrum.com: https://hg.mozilla.org/integration/autoland/rev/836cb7a4cc24 remove unused variables introduced in Bug 1408218. r=drno
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/836cb7a4cc24
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•