Remove unused variables introduced during EUI 64 (MAC-based) IPv6 candidate gathering

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P2
normal
Rank:
15
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mjf, Assigned: mjf)

Tracking

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
Bug 1408218 introduced two new variables (contains_mac_based_ipv6 and contains_teredo_ipv6) that are set but never used.  They should be removed.
Assignee

Updated

2 years ago
Assignee: nobody → mfroman
Blocks: 1408218
Rank: 15
Priority: -- → P2
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8926037 [details]
Bug 1415249 - remove unused variables introduced in Bug 1408218.

https://reviewboard.mozilla.org/r/197264/#review202412

Lgtm and thanks for the fix
Attachment #8926037 - Flags: review?(drno) → review+

Comment 3

2 years ago
mozreview-review
Comment on attachment 8926037 [details]
Bug 1415249 - remove unused variables introduced in Bug 1408218.

https://reviewboard.mozilla.org/r/197264/#review202416


C/C++ static analysis found 0 defects in this patch.

You can run this analysis locally with: `./mach static-analysis check path/to/file.cpp`

Comment 4

2 years ago
Pushed by mfroman@nostrum.com:
https://hg.mozilla.org/integration/autoland/rev/836cb7a4cc24
remove unused variables introduced in Bug 1408218. r=drno

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/836cb7a4cc24
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.