1415263 - [Form Autofill] Accesskeys in form autofill doorhanger are not localizable

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, defect, P3)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

The accesskey for "Create New Address" (formautofill.properties:createAddressLabel) button in the form autofill doorhanger is not localizable. This doorhanger appears when a form is filled with new address or new field is added to a previously filled address. Tracking it down to the code I found out there are more in https://dxr.mozilla.org/mozilla-central/source/browser/extensions/formautofill/FormAutofillDoorhanger.jsm (just Ctrl+F for accessKey). I haven't looked in any other related files, so there might be more.

Comment 1

[Steve Chung [:steveck]]

Attachment: Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

Review commit: https://reviewboard.mozilla.org/r/197946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197946/

Comment 2

[Steve Chung [:steveck]]

Comment on attachment 8926697 [details]
Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

Hi flod,
I add accesskey localization string for the doorhanger button label, but I'm not sure if you'll need more comment/note for the accesskey cause I rarely see people comment for this. Feel free to ask me to add comment for accesskey if you think it's necessary.

Comment 3

[Francesco Lodolo [:flod]]

Comment on attachment 8926697 [details]
Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

Ideally, we should have used feature.label, and feature.accesskey for label and access keys. 

Having said that, the patch looks good as it is, no point in wasting existing localizations.

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8926697 [details]
Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

Ehm, that was meant as an f+

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8926697 [details]
Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

https://reviewboard.mozilla.org/r/197946/#review203574

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40f071c58bf9
[Form Autofill] Make accesskeys in form autofill doorhanger localizable. r=lchang

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/40f071c58bf9