[Form Autofill] Accesskeys in form autofill doorhanger are not localizable

RESOLVED FIXED in Firefox 58

Status

()

Toolkit
Form Autofill
P3
normal
RESOLVED FIXED
12 days ago
9 days ago

People

(Reporter: MikkCZ, Assigned: steveck)

Tracking

(Blocks: 1 bug)

58 Branch
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [form autofill:V2], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

The accesskey for "Create New Address" (formautofill.properties:createAddressLabel) button in the form autofill doorhanger is not localizable. This doorhanger appears when a form is filled with new address or new field is added to a previously filled address. Tracking it down to the code I found out there are more in https://dxr.mozilla.org/mozilla-central/source/browser/extensions/formautofill/FormAutofillDoorhanger.jsm (just Ctrl+F for accessKey). I haven't looked in any other related files, so there might be more.
Priority: -- → P3

Updated

12 days ago
Blocks: 1415079
No longer blocks: 990176
Whiteboard: [form autofill:V2]

Updated

12 days ago
Flags: needinfo?(schung)

Updated

11 days ago
Component: Form Manager → Form Autofill
Comment hidden (mozreview-request)
(Assignee)

Updated

11 days ago
Assignee: nobody → schung
Status: NEW → ASSIGNED
Flags: needinfo?(schung)
(Assignee)

Comment 2

11 days ago
Comment on attachment 8926697 [details]
Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

Hi flod,
I add accesskey localization string for the doorhanger button label, but I'm not sure if you'll need more comment/note for the accesskey cause I rarely see people comment for this. Feel free to ask me to add comment for accesskey if you think it's necessary.
Attachment #8926697 - Flags: feedback?(francesco.lodolo)
Comment on attachment 8926697 [details]
Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

Ideally, we should have used feature.label, and feature.accesskey for label and access keys. 

Having said that, the patch looks good as it is, no point in wasting existing localizations.
Attachment #8926697 - Flags: feedback?(francesco.lodolo) → feedback-
Comment on attachment 8926697 [details]
Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

Ehm, that was meant as an f+
Attachment #8926697 - Flags: feedback- → feedback+

Comment 5

10 days ago
mozreview-review
Comment on attachment 8926697 [details]
Bug 1415263 - [Form Autofill] Make accesskeys in form autofill doorhanger localizable.

https://reviewboard.mozilla.org/r/197946/#review203574
Attachment #8926697 - Flags: review?(lchang) → review+

Comment 6

10 days ago
Pushed by lchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40f071c58bf9
[Form Autofill] Make accesskeys in form autofill doorhanger localizable. r=lchang

Comment 7

9 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/40f071c58bf9
Status: ASSIGNED → RESOLVED
Last Resolved: 9 days ago
status-firefox58: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.