Closed Bug 1415266 Opened 2 years ago Closed 2 years ago

Re-enable Pocket stories

Categories

(Firefox for Android :: Activity Stream, defect, P1)

All
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox56 --- unaffected
firefox57 --- verified
firefox58 --- verified

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file)

We decided to ship AS/pocket in 57 so we should toggle the feature flag: https://mail.mozilla.org/pipermail/firefox-dev/2017-November/005914.html

History: we added a feature flag and disabled it in bug 1411657.
Comment on attachment 8926043 [details]
Bug 1415266: Enable Pocket by default.

https://reviewboard.mozilla.org/r/197272/#review202434

Simple default bool change.
Attachment #8926043 - Flags: review?(liuche) → review+
Comment on attachment 8926043 [details]
Bug 1415266: Enable Pocket by default.

Approval Request Comment
[Feature/Bug causing the regression]: Product considered not shipping AS/Pocket in 57 but have decided to (comment 0). I previously added feature flags, preferred to off in bug 1411657.

[User impact if declined]: Users will have an inconsistent experience across platforms with Pocket disabled on Android but AS + Pocket shipping on desktop
[Is this code covered by automated tests?]: Tangentially: we have a test to make sure the AS Pocket links include a referrer header when Pocket is enabled.
[Has the fix been verified in Nightly?]: Sort of – the code used to ship with true as the preference default (but I made a small change to add the feature flags so the code isn't identical to how it used to be).

[Needs manual test from QE? If yes, steps to reproduce]: Ideal if Bogdan could verify:
1) Launch fennec on a clean build (expected: Pocket is enabled)
2) Go to AS home panel settings (expected: Pocket option is enabled)
3) Disable Pocket, return to homescreen (expected: Pocket is disabled)
4) Returns to settings, enable Pocket, return to homescreen (expected: Pocket is enabled)

[List of other uplifts needed for the feature/fix]: None atm
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's a boolean preference swap and we largely knew the code was working before so it should continue working
[String changes made/needed]: None

NI Sylvestre to make sure this happens.
Flags: needinfo?(sledru)
Attachment #8926043 - Flags: approval-mozilla-beta?
Ritu is the release owner.
Flags: needinfo?(sledru) → needinfo?(rkothari)
Comment on attachment 8926043 [details]
Bug 1415266: Enable Pocket by default.

Product team's decision, must fix, beta57+
Flags: needinfo?(rkothari)
Attachment #8926043 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/mozilla-central/rev/78be743420f1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Verified on the latest Nightly and Release 57 RC build 2 following the steps in Comment 4 and everything works as expected.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.