1415326 - MotionMark CSS bouncing clipped rectanges runs very poorly

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

http://browserbench.org/MotionMark/developer.html?test-interval=30&display=minimal&tiles=big&controller=ramp&frame-rate=50&kalman-process-error=1&kalman-measurement-error=4&time-measurement=performance&suite-name=HTMLsuite&test-name=CSSbouncingclippedrects&complexity=388

I get a score of 69. Chrome gets 400

This is a bunch of transformed rectangles each with a clip mask specified by a polygon.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I think we might be painting the blob images for the clip masks more than necessary.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

So we're definitely painting new items every frame, but the new items don't obviously show up.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Also, all of the squares share a single clip path, so if webrender could share them we would go much much faster.

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Also, all of the squares share a single clip path, so if webrender could
> share them we would go much much faster.

Should we open a separate bug for this part?

Comment 5

[Kartikaya Gupta (email:[e-mail])]

(In reply to Milan Sreckovic [:milan] from comment #4)
> (In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> > Also, all of the squares share a single clip path, so if webrender could
> > share them we would go much much faster.
> 
> Should we open a separate bug for this part?

Yes please. Depending on how the display list is structured this might be pretty simple to do.

Comment 6

[Jeff Muizelaar [:jrmuizel]]

Attachment: Tolerate slight changes in scale

This helps us avoid rerasterizing the blob images every frame. This makes a huge difference in performance. Our score goes from approx 75 to 380. Current Firefox gets about 200.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8927021 [details] [diff] [review]
Tolerate slight changes in scale

Review of attachment 8927021 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderCommandBuilder.cpp
@@ +507,5 @@
>    // region is unknown until we traverse the displaylist contained by it.
>    if (geometry && !fallbackData->IsInvalid() &&
>        aItem->GetType() != DisplayItemType::TYPE_FILTER &&
> +      aItem->GetType() != DisplayItemType::TYPE_SVG_WRAPPER
> +      differentScale) {

you're missing an operator here

Comment 8

[Ethan Lin[:ethlin]]

Of course you will fix the compilation errors before landing.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5bee2596ae4d
Tolerate slight changes in scale for fallback items. r=ethlin

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5bee2596ae4d