Closed
Bug 1415335
Opened 9 years ago
Closed 9 years ago
Move misc functionality out of client.mk
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
No description provided.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Comment 5•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926110 [details]
Bug 1415335 - Remove build_all and clobber_all targets;
https://reviewboard.mozilla.org/r/197338/#review202524
Attachment #8926110 -
Flags: review+
Comment 6•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926111 [details]
Bug 1415335 - Move spaces in path check to configure;
https://reviewboard.mozilla.org/r/197340/#review202528
Yep. Do we have a "paths-in-spaces" metaticket to link to?
Attachment #8926111 -
Flags: review+
Comment 7•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926112 [details]
Bug 1415335 - Move Windows line endings detection to configure;
https://reviewboard.mozilla.org/r/197342/#review202534
Huge plus one for removing Perl invocations!
::: build/moz.configure/init.configure:75
(Diff revision 1)
> + ' * The source tree appears to have Windows-style line endings.\n'
> + ' *\n'
> + ' * This is likely a result of using Git with Git configured to\n'
> + ' * use Windows-style line endings.\n'
> + ' *\n'
> + ' * To convert the working copy to UNIX-style line endings, run\n'
Maybe say, "If you're using git...". What should folks do if they're not using git?
Attachment #8926112 -
Flags: review+
Comment 8•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926113 [details]
Bug 1415335 - Remove clobber target;
https://reviewboard.mozilla.org/r/197344/#review202536
Sure.
Attachment #8926113 -
Flags: review+
Updated•9 years ago
|
Attachment #8926110 -
Flags: review?(core-build-config-reviews)
Attachment #8926111 -
Flags: review?(core-build-config-reviews)
Attachment #8926112 -
Flags: review?(core-build-config-reviews)
Attachment #8926113 -
Flags: review?(core-build-config-reviews)
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Comment 13•9 years ago
|
||
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1557f5e4e889
Remove build_all and clobber_all targets; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/9fd30a79e468
Move spaces in path check to configure; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/3894f3262cbc
Move Windows line endings detection to configure; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/270e0b97ec67
Remove clobber target; r=nalexander
| Assignee | ||
Updated•9 years ago
|
Attachment #8926110 -
Flags: review?(core-build-config-reviews)
| Assignee | ||
Updated•9 years ago
|
Attachment #8926111 -
Flags: review?(core-build-config-reviews)
| Assignee | ||
Updated•9 years ago
|
Attachment #8926112 -
Flags: review?(core-build-config-reviews)
| Assignee | ||
Updated•9 years ago
|
Attachment #8926113 -
Flags: review?(core-build-config-reviews)
| Assignee | ||
Comment 14•9 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8926111 [details]
Bug 1415335 - Move spaces in path check to configure;
https://reviewboard.mozilla.org/r/197340/#review202528
I don't believe so.
Comment 15•9 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1557f5e4e889
https://hg.mozilla.org/mozilla-central/rev/9fd30a79e468
https://hg.mozilla.org/mozilla-central/rev/3894f3262cbc
https://hg.mozilla.org/mozilla-central/rev/270e0b97ec67
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•