1415438 - Move mReopenOnError from ChannelMediaResource to ChannelMediaResource::Listener

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/dom/media/ChannelMediaResource.cpp#727-729

mReopenOnError is a flag to reopen the channel when resume fails. It makes more sense to associate this member with the channel we are resuming.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1415438 - move mReopenOnError from ChannelMediaResource to ChannelMediaResource::Listener.

http://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/dom/media/ChannelMediaResource.cpp#727-729

mReopenOnError is a flag to reopen the channel when resume fails.
It makes more sense to associate this member with the channel we are resuming.

Review commit: https://reviewboard.mozilla.org/r/198336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198336/

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8927117 [details]
Bug 1415438 - move mReopenOnError from ChannelMediaResource to ChannelMediaResource::Listener.

https://reviewboard.mozilla.org/r/198336/#review203572

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8927117 [details]
Bug 1415438 - move mReopenOnError from ChannelMediaResource to ChannelMediaResource::Listener.

https://reviewboard.mozilla.org/r/198336/#review203596

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0bfda215869
move mReopenOnError from ChannelMediaResource to ChannelMediaResource::Listener. r=bechen,gerald

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0bfda215869