Closed Bug 1415469 Opened 2 years ago Closed 2 years ago

Remove unused variable from TDR process

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: kechen, Assigned: kechen)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

After Bug 1363126, we notify all tabs for device reset through PContent within one single message which prevents us from unsynchronized device state between tabs.

Therefore, we might not need mDeviceResetSequenceNumber[1] to ensure the tab states anymore.

[1] https://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/gfx/layers/client/ClientLayerManager.cpp#246
Priority: -- → P3
Whiteboard: [gfx-noted]
Comment on attachment 8926304 [details]
Bug 1415469 - Remove mDeviceResetSequenceNumber from TDR process since we don't need it anymore;

https://reviewboard.mozilla.org/r/197584/#review203434

I think you are right, this is stale code from before we overhauled device resets. Thanks for cleaning it up!
Attachment #8926304 - Flags: review?(dvander) → review+
The try result[1] looks good, the failures are not related to this fix.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7cc994586bd26c8955781157b02a4cebac09795
Keywords: checkin-needed
Target Milestone: mozilla58 → mozilla59
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c9117e83e3a2
Remove mDeviceResetSequenceNumber from TDR process since we don't need it anymore; r=dvander
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c9117e83e3a2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.