1415469 - Remove unused variable from TDR process

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Kevin Chen[:kechen] (UTC + 8)]

After Bug 1363126, we notify all tabs for device reset through PContent within one single message which prevents us from unsynchronized device state between tabs.

Therefore, we might not need mDeviceResetSequenceNumber[1] to ensure the tab states anymore.

[1] https://searchfox.org/mozilla-central/rev/ed212c79cfe86357e9a5740082b9364e7f6e526f/gfx/layers/client/ClientLayerManager.cpp#246

Comment 1

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Bug 1415469 - Remove mDeviceResetSequenceNumber from TDR process since we don't need it anymore;

Review commit: https://reviewboard.mozilla.org/r/197584/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197584/

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8926304 [details]
Bug 1415469 - Remove mDeviceResetSequenceNumber from TDR process since we don't need it anymore;

https://reviewboard.mozilla.org/r/197584/#review203434

I think you are right, this is stale code from before we overhauled device resets. Thanks for cleaning it up!

Comment 3

[Kevin Chen[:kechen] (UTC + 8)]

The try result[1] looks good, the failures are not related to this fix.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7cc994586bd26c8955781157b02a4cebac09795

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9117e83e3a2
Remove mDeviceResetSequenceNumber from TDR process since we don't need it anymore; r=dvander

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/c9117e83e3a2