Closed Bug 141552 Opened 18 years ago Closed 18 years ago

Preferences should not generate build warnings

Categories

(Core :: Preferences: Backend, defect, trivial)

defect
Not set
trivial

Tracking

()

VERIFIED FIXED

People

(Reporter: bnesse, Assigned: bnesse)

References

Details

Attachments

(2 files)

nsPrefBranch.cpp generates two compiler warnings on the "brad" tinderbox when 
building. One for an unused variable, and one for a "this variable might be used 
uninitialized". Every now and then I notice these and they annoy me.
Attached patch Cleanup patchSplinter Review
This patch cleans up the aforementioned warnings, as well as others associated
to alecf and ltabb caused by leftover cruft from previous cleanup.

alecf, jag, could you please r/sr these changes?
Comment on attachment 81902 [details] [diff] [review]
Cleanup patch

sr=alecf
Attachment #81902 - Flags: superreview+
Comment on attachment 81902 [details] [diff] [review]
Cleanup patch

r=jag
Attachment #81902 - Flags: review+
Fix checked in.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Blocks: 59652
This fixed seems to have introduced one new warning. Currently
(http://tinderbox.mozilla.org/SeaMonkey/warn1020293880.9655.html) Tbox shows 1
warning on brad in libpref:

modules/libpref/src/prefapi.cpp:1120 
   `enum PLDHashOperator pref_addChild(PLDHashTable *, PLDHashEntryHdr *,
unsigned int, void *)' defined but not used
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Oh slap me with a wet noodle! I forgot to kill the callback associated with:
PREF_CreateChildList(const char* parent_node, char **child_list)

Geez Alec, why didn't you just delete all this stuff when you reworked prefapi.c ;)
Status: REOPENED → ASSIGNED
Patch to remove the remainder of the PREF_CreateChildList support. alecf, jag,
you want to rs some more dead code removal please?
Comment on attachment 82050 [details] [diff] [review]
Additional cleanup patch

sr=jag
Attachment #82050 - Flags: superreview+
Comment on attachment 82050 [details] [diff] [review]
Additional cleanup patch

r=blythe
Attachment #82050 - Flags: review+
Additional cleanup patch checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
The most recent brad warnings list
(http://tinderbox.mozilla.org/SeaMonkey/warn1020373020.5900.html) does not show
any libpref warnings. Marking VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.