141552 - Preferences should not generate build warnings

Status: VERIFIED FIXED

(Core :: Preferences: Backend, defect)

Description

[Brian Nesse (gone)]

nsPrefBranch.cpp generates two compiler warnings on the "brad" tinderbox when 
building. One for an unused variable, and one for a "this variable might be used 
uninitialized". Every now and then I notice these and they annoy me.

Comment 1

[Brian Nesse (gone)]

Attachment: Cleanup patch

This patch cleans up the aforementioned warnings, as well as others associated
to alecf and ltabb caused by leftover cruft from previous cleanup.

alecf, jag, could you please r/sr these changes?

Comment 2

[Alec Flett]

Comment on attachment 81902 [details] [diff] [review]
Cleanup patch

sr=alecf

Comment 3

[jag (Peter Annema)]

Comment on attachment 81902 [details] [diff] [review]
Cleanup patch

r=jag

Comment 4

[Brian Nesse (gone)]

Fix checked in.

Comment 5

[Aleksey Nogin]

This fixed seems to have introduced one new warning. Currently
(http://tinderbox.mozilla.org/SeaMonkey/warn1020293880.9655.html) Tbox shows 1
warning on brad in libpref:

modules/libpref/src/prefapi.cpp:1120 
   `enum PLDHashOperator pref_addChild(PLDHashTable *, PLDHashEntryHdr *,
unsigned int, void *)' defined but not used

Comment 6

[Brian Nesse (gone)]

Oh slap me with a wet noodle! I forgot to kill the callback associated with:
PREF_CreateChildList(const char* parent_node, char **child_list)

Geez Alec, why didn't you just delete all this stuff when you reworked prefapi.c ;)

Comment 7

[Brian Nesse (gone)]

Attachment: Additional cleanup patch

Patch to remove the remainder of the PREF_CreateChildList support. alecf, jag,
you want to rs some more dead code removal please?

Comment 8

[jag (Peter Annema)]

Comment on attachment 82050 [details] [diff] [review]
Additional cleanup patch

sr=jag

Comment 9

[Brian Nesse (gone)]

Comment on attachment 82050 [details] [diff] [review]
Additional cleanup patch

r=blythe

Comment 10

[Brian Nesse (gone)]

Additional cleanup patch checked in.

Comment 11

[Aleksey Nogin]

The most recent brad warnings list
(http://tinderbox.mozilla.org/SeaMonkey/warn1020373020.5900.html) does not show
any libpref warnings. Marking VERIFIED FIXED.