1415533 - Remove highlightnonmatches feature not used in Firefox but used in Thunderbird in central and essential functionality

Status: RESOLVED WONTFIX

(Toolkit :: Autocomplete, enhancement)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1415533 - Remove unused highlightnonmatches feature

Review commit: https://reviewboard.mozilla.org/r/197624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197624/

Comment 2

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=10606efb4900aee382c031e972312a66819801db

Comment 3

[Marco Bonardo [:mak]]

Appears to be used by Thunderbird https://dxr.mozilla.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#4764 and https://dxr.mozilla.org/comm-central/source/mail/components/compose/content/MsgComposeCommands.js#4820
(the pref is set to true by default)

I'm not sure how much critical it is.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Marco Bonardo [::mak] from comment #3)
> Appears to be used by Thunderbird
> https://dxr.mozilla.org/comm-central/source/mail/components/compose/content/
> MsgComposeCommands.js#4764 and
> https://dxr.mozilla.org/comm-central/source/mail/components/compose/content/
> MsgComposeCommands.js#4820
> (the pref is set to true by default)
> 
> I'm not sure how much critical it is.

They're using the xpfe autocomplete binding, aren't they?

Comment 5

[Jorg K (CEST = GMT+2)]

We're using toolkit autocomplete since TB 31 (2014).

This feature is used to colour a non-matched entry in red. In our case, we look an entered e-mail address up in the address book(s), and of not found, it's coloured in red. That shows the user that he/she potentially mistyped.

That feature is *super important*. It is an integral part of e-mail addressing. Removing it would be pretty fatal.

Please make this WONTFIX.

Comment 6

[Dão Gottwald [:dao]]

Okay.

Comment 7

[Frank-Rainer Grahl (:frg)]

> They're using the xpfe autocomplete binding, aren't they?

This is only used in suite.