Closed Bug 1415534 Opened 7 years ago Closed 7 years ago

Custom Tab not enabled on 57 RC

Categories

(Firefox for Android Graveyard :: Custom Tabs, defect)

Firefox 57
ARM
Android
defect
Not set
normal

Tracking

(firefox57blocking fixed)

VERIFIED FIXED
Tracking Status
firefox57 blocking fixed

People

(Reporter: sflorean, Unassigned)

References

Details

Environment: Device: Samsung Galaxy Tab 3 (Android 7.0), Oneplus Two (Android 6.0.1); Build: 57.0; Steps to reproduce: 1. Set Firefox 57.0 - default browser; 2. Open Gmail and tap on a link Expected result: The page/link opens using Custom Tab activity. Actual result: The page/link opens in Firefox. Notes: - This feature has a GO for 57 in Trello card: https://trello.com/c/SqPMWz0L/271-fennec-ship-chrome-custom-tabs
Flags: needinfo?(wehuang)
Was this working in 57.0b15?
Flags: needinfo?(sorina.florean)
(In reply to Julien Cristau [:jcristau] from comment #1) > Was this working in 57.0b15? Yes, on 57 Beta 15 Custom tab was working. We tested on the same devices as well to make sure.
Flags: needinfo?(sorina.florean)
Depends on: 1329152
Apparently this is controlled by switchboard, so who has access to that these days?
Flags: needinfo?(max)
Flags: needinfo?(jcheng)
I just tested using the latest beta with Google custom test client app https://github.com/GoogleChrome/custom-tabs-client and walkingice's custom tab test client app https://github.com/walkingice/CustomTabsLauncher Please note that since we use switchboard, we need to launch our app first to initialize switchboard ( so all experiments will be enabled) That means that Custom Tab will work only after the users open our app once. The client app can decide which browser they want to use. I've never successfully used Gmail or Twitter with our custom tab. They both open Chrome even Fennec is my default browser. So I think it's better if we use another app to test Custom Tab?
Flags: needinfo?(sorina.florean)
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #3) > Apparently this is controlled by switchboard, so who has access to that > these days? btw I accessed switchboard recently but didn't touch custom-tabs part. The settings are correct to me[1], just we need to add release channel in the "match" part once 57 releases. [1] https://firefox.settings.services.mozilla.com/v1/buckets/fennec/collections/experiments/records
(In reply to Nevin Chen [:nechen] from comment #4) > I just tested using the latest beta with Google custom test client app > https://github.com/GoogleChrome/custom-tabs-client > and walkingice's custom tab test client app > https://github.com/walkingice/CustomTabsLauncher > > Please note that since we use switchboard, we need to launch our app first > to initialize switchboard ( so all experiments will be enabled) > That means that Custom Tab will work only after the users open our app once. > > The client app can decide which browser they want to use. I've never > successfully used Gmail or Twitter with our custom tab. They both open > Chrome even Fennec is my default browser. > > So I think it's better if we use another app to test Custom Tab? I've tested also with Yahnac and News&Weather and the results are the same.
Flags: needinfo?(sorina.florean)
If I understand correctly this is now enabled for "release" builds in switchboard, so should be working?
Sorina confirmed in email this now works as expected.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(wehuang)
Flags: needinfo?(max)
Flags: needinfo?(jcheng)
Resolution: --- → FIXED
tracking-fennec: ? → ---
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.