Closed
Bug 1415534
Opened 7 years ago
Closed 7 years ago
Custom Tab not enabled on 57 RC
Categories
(Firefox for Android Graveyard :: Custom Tabs, defect)
Tracking
(firefox57blocking fixed)
VERIFIED
FIXED
People
(Reporter: sflorean, Unassigned)
References
Details
Environment:
Device: Samsung Galaxy Tab 3 (Android 7.0), Oneplus Two (Android 6.0.1);
Build: 57.0;
Steps to reproduce:
1. Set Firefox 57.0 - default browser;
2. Open Gmail and tap on a link
Expected result:
The page/link opens using Custom Tab activity.
Actual result:
The page/link opens in Firefox.
Notes:
- This feature has a GO for 57 in Trello card:
https://trello.com/c/SqPMWz0L/271-fennec-ship-chrome-custom-tabs
Reporter | ||
Updated•7 years ago
|
Flags: needinfo?(wehuang)
Comment 1•7 years ago
|
||
Was this working in 57.0b15?
tracking-firefox57:
--- → blocking
Flags: needinfo?(sorina.florean)
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Julien Cristau [:jcristau] from comment #1)
> Was this working in 57.0b15?
Yes, on 57 Beta 15 Custom tab was working. We tested on the same devices as well to make sure.
Flags: needinfo?(sorina.florean)
Apparently this is controlled by switchboard, so who has access to that these days?
Flags: needinfo?(max)
Flags: needinfo?(jcheng)
Comment 4•7 years ago
|
||
I just tested using the latest beta with Google custom test client app
https://github.com/GoogleChrome/custom-tabs-client
and walkingice's custom tab test client app
https://github.com/walkingice/CustomTabsLauncher
Please note that since we use switchboard, we need to launch our app first to initialize switchboard ( so all experiments will be enabled)
That means that Custom Tab will work only after the users open our app once.
The client app can decide which browser they want to use. I've never successfully used Gmail or Twitter with our custom tab. They both open Chrome even Fennec is my default browser.
So I think it's better if we use another app to test Custom Tab?
Flags: needinfo?(sorina.florean)
Comment 5•7 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #3)
> Apparently this is controlled by switchboard, so who has access to that
> these days?
btw I accessed switchboard recently but didn't touch custom-tabs part. The settings are correct to me[1], just we need to add release channel in the "match" part once 57 releases.
[1] https://firefox.settings.services.mozilla.com/v1/buckets/fennec/collections/experiments/records
Reporter | ||
Comment 6•7 years ago
|
||
(In reply to Nevin Chen [:nechen] from comment #4)
> I just tested using the latest beta with Google custom test client app
> https://github.com/GoogleChrome/custom-tabs-client
> and walkingice's custom tab test client app
> https://github.com/walkingice/CustomTabsLauncher
>
> Please note that since we use switchboard, we need to launch our app first
> to initialize switchboard ( so all experiments will be enabled)
> That means that Custom Tab will work only after the users open our app once.
>
> The client app can decide which browser they want to use. I've never
> successfully used Gmail or Twitter with our custom tab. They both open
> Chrome even Fennec is my default browser.
>
> So I think it's better if we use another app to test Custom Tab?
I've tested also with Yahnac and News&Weather and the results are the same.
Flags: needinfo?(sorina.florean)
Comment 7•7 years ago
|
||
If I understand correctly this is now enabled for "release" builds in switchboard, so should be working?
Comment 8•7 years ago
|
||
Sorina confirmed in email this now works as expected.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(wehuang)
Flags: needinfo?(max)
Flags: needinfo?(jcheng)
Resolution: --- → FIXED
Updated•7 years ago
|
tracking-fennec: ? → ---
Reporter | ||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•