1415537 - Rename mTabstrip to something more meaningful

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

mTabstrip is too ambiguous. The property actually refers to the <arrowscrollbox> element.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1415537 - Rename mTabstrip to arrowScrollbox.

Review commit: https://reviewboard.mozilla.org/r/197644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197644/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8926360 [details]
Bug 1415537 - Rename mTabstrip to arrowScrollbox.

https://reviewboard.mozilla.org/r/197644/#review202882

::: browser/base/content/tabbrowser.xml:7054
(Diff revision 1)
> -              this.mTabstrip.ensureElementIsVisible(aTab);
> +              this.arrowScrollbox.ensureElementIsVisible(aTab);
>                return;
>              }
>  
> -            this.mTabstrip.scrollByPixels(this.mTabstrip._isRTLScrollbox ?
> +            this.arrowScrollbox.scrollByPixels(this.arrowScrollbox._isRTLScrollbox ?
>                                            selected.right - scrollRect.right :

please fix the indent here

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8926360 [details]
Bug 1415537 - Rename mTabstrip to arrowScrollbox.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197644/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b36ace8b707
Rename mTabstrip to arrowScrollbox. r=florian

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7b36ace8b707