Closed Bug 1415537 Opened 2 years ago Closed 2 years ago

Rename mTabstrip to something more meaningful

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

mTabstrip is too ambiguous. The property actually refers to the <arrowscrollbox> element.
Comment on attachment 8926360 [details]
Bug 1415537 - Rename mTabstrip to arrowScrollbox.

https://reviewboard.mozilla.org/r/197644/#review202882

::: browser/base/content/tabbrowser.xml:7054
(Diff revision 1)
> -              this.mTabstrip.ensureElementIsVisible(aTab);
> +              this.arrowScrollbox.ensureElementIsVisible(aTab);
>                return;
>              }
>  
> -            this.mTabstrip.scrollByPixels(this.mTabstrip._isRTLScrollbox ?
> +            this.arrowScrollbox.scrollByPixels(this.arrowScrollbox._isRTLScrollbox ?
>                                            selected.right - scrollRect.right :

please fix the indent here
Attachment #8926360 - Flags: review?(florian) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b36ace8b707
Rename mTabstrip to arrowScrollbox. r=florian
https://hg.mozilla.org/mozilla-central/rev/7b36ace8b707
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Blocks: 1189155
No longer blocks: 1387013
You need to log in before you can comment on or make changes to this bug.