1415554 - Update Inspector to use prop-types and react-dom-factories

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

There are a number of reasons for this:

1. We need to have the modules available for code from devtools-core, which uses them.
2. It begins the process of getting rid of React deprecation warnings.
3. It prepares us to upgrade to React 16.

Versioning info from devtools-core github repo:

"prop-types": "^15.6.0"
"react-dom-factories": "^1.0.2"

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1415554 - Inspector to use prop-types and react-dom-factories

Review commit: https://reviewboard.mozilla.org/r/197758/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/197758/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8926502 [details]
Bug 1415554 - Inspector to use prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/197758/#review203524

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39beeec35ecc
Inspector to use prop-types and react-dom-factories r=gl

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing devtools/client/shared/components/test/mochitest/test_tabs_accessibility.html r=backout on a CLOSED TREE

There were many test fails: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=39beeec35eccb3d38190a95cc50268ba7f7743d6&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry&selectedJob=143510065

Error log: https://treeherder.mozilla.org/logviewer.html#?job_id=143510065&repo=mozilla-inbound&lineNumber=5447

Back out: https://hg.mozilla.org/integration/mozilla-inbound/rev/d89736edd7a95f1f24222ae340a6509b7a7a703b

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8926502 [details]
Bug 1415554 - Inspector to use prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/197758/#review203562

::: devtools/client/inspector/boxmodel/components/BoxModelProperties.js
(Diff revision 1)
> -  PureComponent,
> -} = require("devtools/client/shared/vendor/react");
>  const { LocalizationHelper } = require("devtools/shared/l10n");
>  
>  const ComputedProperty = createFactory(require("./ComputedProperty"));
> -

Avoid removing the new line here

::: devtools/client/inspector/fonts/components/FontList.js
(Diff revision 1)
> -  PropTypes,
> -  PureComponent,
> -} = require("devtools/client/shared/vendor/react");
>  
>  const Font = createFactory(require("./Font"));
> -

Same as above

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8926502 [details]
Bug 1415554 - Inspector to use prop-types and react-dom-factories

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/197758/diff/1-2/

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8926502 [details]
Bug 1415554 - Inspector to use prop-types and react-dom-factories

https://reviewboard.mozilla.org/r/197758/#review203910

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c256e7ec78df
Inspector to use prop-types and react-dom-factories r=gl

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/c256e7ec78df