1415569 - Make version 10.0.14393.0 the minimum Win10 SDK required for building Firefox

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement, P1)

Comment 1

[Bob Owen (:bobowen)]

Attachment: Make version 10.0.14393.0 the minimum Win10 SDK required for building Firefox

This is required for the latest chromium sandbox update.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8926492 [details] [diff] [review]
Make version 10.0.14393.0 the minimum Win10 SDK required for building Firefox

Review of attachment 8926492 [details] [diff] [review]:
-----------------------------------------------------------------

I haven't followed the latest msvc/sdk related things, so I'd rather someone more in the loop looked at this. All I can say, since I saw that for another review, is that we still allow to build with msvc 2015. Does that SDK work with that version?

Comment 3

[Bob Owen (:bobowen)]

(In reply to Mike Hommey [:glandium] from comment #2)
...
> I haven't followed the latest msvc/sdk related things, so I'd rather someone
> more in the loop looked at this. All I can say, since I saw that for another
> review, is that we still allow to build with msvc 2015. Does that SDK work
> with that version?

OK thanks Mike (I'd forgotten about the new build review distribution thing).

Yes I'm still building with VS2015 at the moment.
This is the latest SDK available to install as part of the VS installer and the one that we were using on automation until recently.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8926492 [details] [diff] [review]
Make version 10.0.14393.0 the minimum Win10 SDK required for building Firefox

Review of attachment 8926492 [details] [diff] [review]:
-----------------------------------------------------------------

Kind of a bummer, but OK. For people who have MSVC installed, are there simple steps we can provide for updating to the latest SDK?

Comment 5

[Bob Owen (:bobowen)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #4)
...
> Kind of a bummer, but OK. For people who have MSVC installed, are there
> simple steps we can provide for updating to the latest SDK?

Provide where, do you mean in the error message?

When you say MSVC, I assume you mean Visual Studio (I don't think a stand alone product is available any more).
It can be installed from the VS2015 or VS2017 installer, for VS2017 they probably already have a later version.

Comment 6

[(not currently active) Ted Mielczarek]

Putting the steps in a wiki page or in-tree build docs that we reference from the error message would be great. If it's just "run the VS installer and install updates", that's fine too. If it's likely that people already have the latest SDK because this is not a bleeding-edge version we're requiring then it's probably not a problem.

Comment 7

[Bob Owen (:bobowen)]

OK thanks, I suspect a lot of people will already have at least this version, almost certainly for the people using VS2017.

I've just added " This or a later version can be installed using the Visual Studio installer." to the message anyway as it can't hurt.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c265b411490
Make version 10.0.14393.0 the minimum Win10 SDK required for building Firefox. r=ted

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8c265b411490