1415675 - Web Authentication - Support AbortSignal types

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/him)]

The Create and Get methods need to accept an AbortController, and 1) call the callback, if any, upon an abort, and 2) send a cancel (like we do with a tab switch) when the abort is called by Javascript.

Comment 1

[Phabricator Automation]

Comment on attachment 8928427 [details]
Bug 1415675 - Web Authentication - Support AbortSignal types r=jcj

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D245#5917

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cbcb61de77652c1e367d8931a14621c671bd547

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

I'm honestly a little surprised to see no failures. Well, let's give it a shot and push it.

Comment 4

[Tim Taubert [:ttaubert] (inactive)]

No, let's wait for a DOM peer to r+. Sorry ;)

Comment 5

[Phabricator Automation]

Comment on attachment 8928427 [details]
Bug 1415675 - Web Authentication - Support AbortSignal types r=jcj

J.C. Jones [:jcj] has been removed from the revision.

https://phabricator.services.mozilla.com/D245#5967

Comment 6

[Phabricator Automation]

Comment on attachment 8928427 [details]
Bug 1415675 - Web Authentication - Support AbortSignal types r=jcj

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D245#6006

Comment 7

[Phabricator Automation]

Comment on attachment 8928427 [details]
Bug 1415675 - Web Authentication - Support AbortSignal types r=jcj

Olli Pettay [:smaug] has approved the revision.

https://phabricator.services.mozilla.com/D245#6007

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/805939626996
Web Authentication - Support AbortSignal types r=jcj,smaug

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/805939626996