Web Authentication - Support AbortSignal types

RESOLVED FIXED in Firefox 59

Status

()

enhancement
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jcj, Assigned: ttaubert)

Tracking

(Blocks 1 bug)

Trunk
Future
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 wontfix, firefox59 fixed)

Details

(Whiteboard: [webauthn][webauthn-wd07])

Attachments

(1 attachment)

The Create and Get methods need to accept an AbortController, and 1) call the callback, if any, upon an abort, and 2) send a cancel (like we do with a tab switch) when the abort is called by Javascript.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Blocks: 1388854
Comment on attachment 8928427 [details]
Bug 1415675 - Web Authentication - Support AbortSignal types r=jcj

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D245#5917
Attachment #8928427 - Flags: review+
I'm honestly a little surprised to see no failures. Well, let's give it a shot and push it.
No, let's wait for a DOM peer to r+. Sorry ;)
Comment on attachment 8928427 [details]
Bug 1415675 - Web Authentication - Support AbortSignal types r=jcj

J.C. Jones [:jcj] has been removed from the revision.

https://phabricator.services.mozilla.com/D245#5967
Attachment #8928427 - Flags: review+
Comment on attachment 8928427 [details]
Bug 1415675 - Web Authentication - Support AbortSignal types r=jcj

J.C. Jones [:jcj] has approved the revision.

https://phabricator.services.mozilla.com/D245#6006
Attachment #8928427 - Flags: review+
Attachment #8928427 - Flags: review?(bugs)
Comment on attachment 8928427 [details]
Bug 1415675 - Web Authentication - Support AbortSignal types r=jcj

Olli Pettay [:smaug] has approved the revision.

https://phabricator.services.mozilla.com/D245#6007
Attachment #8928427 - Flags: review+
Attachment #8928427 - Flags: review?(bugs)
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/805939626996
Web Authentication - Support AbortSignal types r=jcj,smaug
https://hg.mozilla.org/mozilla-central/rev/805939626996
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.