Closed Bug 1415699 Opened 2 years ago Closed 2 years ago

Apply LLVM patches needed for Windows code coverage builds

Categories

(Testing :: Code Coverage, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
Attachment #8926590 - Flags: review?(nfroyd)
Comment on attachment 8926590 [details] [diff] [review]
Patch

Review of attachment 8926590 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for including so much information in the patch files!  Makes later archaeology much easier!

Do we want these patches only for the windows builds, or do we want them for the linux/mac builds as well?
Attachment #8926590 - Flags: review?(nfroyd) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a1a5a1cb353
Apply LLVM patches needed to support code coverage on Windows. r=froydnj
(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8926590 [details] [diff] [review]
> Patch
> 
> Review of attachment 8926590 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for including so much information in the patch files!  Makes later
> archaeology much easier!
> 
> Do we want these patches only for the windows builds, or do we want them for
> the linux/mac builds as well?

They should all be Windows-specific, the Clang coverage build on Linux already works (well, it does build, but it does not pass all our tests) without modifications.
https://hg.mozilla.org/mozilla-central/rev/0a1a5a1cb353
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.