1415699 - Apply LLVM patches needed for Windows code coverage builds

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8926590 [details] [diff] [review]
Patch

Review of attachment 8926590 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for including so much information in the patch files!  Makes later archaeology much easier!

Do we want these patches only for the windows builds, or do we want them for the linux/mac builds as well?

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a1a5a1cb353
Apply LLVM patches needed to support code coverage on Windows. r=froydnj

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Nathan Froyd [:froydnj] from comment #2)
> Comment on attachment 8926590 [details] [diff] [review]
> Patch
> 
> Review of attachment 8926590 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for including so much information in the patch files!  Makes later
> archaeology much easier!
> 
> Do we want these patches only for the windows builds, or do we want them for
> the linux/mac builds as well?

They should all be Windows-specific, the Clang coverage build on Linux already works (well, it does build, but it does not pass all our tests) without modifications.

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/0a1a5a1cb353