[webvtt] support multi-line region parsing.

RESOLVED FIXED in Firefox 59

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
11 days ago
3 days ago

People

(Reporter: bechen, Assigned: bechen)

Tracking

unspecified
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

11 days ago
https://www.w3.org/TR/webvtt1/#introduction-other-features example 10:

REGION
id:fred
width:40%
lines:3
regionanchor:0%,100%
viewportanchor:10%,90%
scroll:up
...

Now our parser only support only one line parsing.
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8927752 [details]
Bug 1415821 - Modify .vtt REGION syntax.

https://reviewboard.mozilla.org/r/199022/#review204082
Attachment #8927752 - Flags: review?(alwu) → review+
Per offline discussion, will review the patch again after passing tests.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8927751 [details]
Bug 1415821 - Support multi-line parsing for REGION/STYLE block.

https://reviewboard.mozilla.org/r/199020/#review204786
Attachment #8927751 - Flags: review?(alwu) → review+
Comment on attachment 8928412 [details]
Bug 1415821 - Correct the behavior for BADCUE state.

https://reviewboard.mozilla.org/r/199636/#review204788

::: dom/media/webvtt/vtt.jsm:1360
(Diff revision 1)
>          }
>  
>          var nextIteration = false;
>          while (nextIteration || self.buffer) {
>            nextIteration = false;
> -          if (!line) {
> +          if (self.state == "BADCUE") {

Per offline discussed, should handle "BADCUE" in the following switch statement.
Comment hidden (mozreview-request)
Comment on attachment 8928412 [details]
Bug 1415821 - Correct the behavior for BADCUE state.

https://reviewboard.mozilla.org/r/199636/#review204958
Attachment #8928412 - Flags: review?(alwu) → review+
(Assignee)

Updated

4 days ago
Keywords: checkin-needed

Comment 14

4 days ago
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f276f1cc275
Modify .vtt REGION syntax. r=alwu
https://hg.mozilla.org/integration/autoland/rev/1786297a20df
Support multi-line parsing for REGION/STYLE block. r=alwu
https://hg.mozilla.org/integration/autoland/rev/5a9fbe6806cf
Correct the behavior for BADCUE state. r=alwu
Keywords: checkin-needed

Comment 15

3 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0f276f1cc275
https://hg.mozilla.org/mozilla-central/rev/1786297a20df
https://hg.mozilla.org/mozilla-central/rev/5a9fbe6806cf
Status: NEW → RESOLVED
Last Resolved: 3 days ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.