1415821 - [webvtt] support multi-line region parsing.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Benjamin Chen [:bechen]]

https://www.w3.org/TR/webvtt1/#introduction-other-features example 10:

REGION
id:fred
width:40%
lines:3
regionanchor:0%,100%
viewportanchor:10%,90%
scroll:up
...

Now our parser only support only one line parsing.

Comment 1

[Benjamin Chen [:bechen]]

Attachment: Bug 1415821 - Support multi-line parsing for REGION/STYLE block.

Review commit: https://reviewboard.mozilla.org/r/199020/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199020/

Comment 2

[Benjamin Chen [:bechen]]

Attachment: Bug 1415821 - Modify .vtt REGION syntax.

Review commit: https://reviewboard.mozilla.org/r/199022/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199022/

Comment 3

[Alastor Wu [:alwu]]

Comment on attachment 8927752 [details]
Bug 1415821 - Modify .vtt REGION syntax.

https://reviewboard.mozilla.org/r/199022/#review204082

Comment 4

[Alastor Wu [:alwu]]

Per offline discussion, will review the patch again after passing tests.

Comment 5

[Benjamin Chen [:bechen]]

Comment on attachment 8927751 [details]
Bug 1415821 - Support multi-line parsing for REGION/STYLE block.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199020/diff/1-2/

Comment 6

[Benjamin Chen [:bechen]]

Comment on attachment 8927752 [details]
Bug 1415821 - Modify .vtt REGION syntax.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199022/diff/1-2/

Comment 7

[Benjamin Chen [:bechen]]

Attachment: Bug 1415821 - Correct the behavior for BADCUE state.

Review commit: https://reviewboard.mozilla.org/r/199636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199636/

Comment 8

[Benjamin Chen [:bechen]]

Comment on attachment 8927752 [details]
Bug 1415821 - Modify .vtt REGION syntax.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199022/diff/2-3/

Comment 9

[Benjamin Chen [:bechen]]

Comment on attachment 8927751 [details]
Bug 1415821 - Support multi-line parsing for REGION/STYLE block.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199020/diff/2-3/

Comment 10

[Alastor Wu [:alwu]]

Comment on attachment 8927751 [details]
Bug 1415821 - Support multi-line parsing for REGION/STYLE block.

https://reviewboard.mozilla.org/r/199020/#review204786

Comment 11

[Alastor Wu [:alwu]]

Comment on attachment 8928412 [details]
Bug 1415821 - Correct the behavior for BADCUE state.

https://reviewboard.mozilla.org/r/199636/#review204788

::: dom/media/webvtt/vtt.jsm:1360
(Diff revision 1)
>          }
>  
>          var nextIteration = false;
>          while (nextIteration || self.buffer) {
>            nextIteration = false;
> -          if (!line) {
> +          if (self.state == "BADCUE") {

Per offline discussed, should handle "BADCUE" in the following switch statement.

Comment 12

[Benjamin Chen [:bechen]]

Comment on attachment 8928412 [details]
Bug 1415821 - Correct the behavior for BADCUE state.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/199636/diff/1-2/

Comment 13

[Alastor Wu [:alwu]]

Comment on attachment 8928412 [details]
Bug 1415821 - Correct the behavior for BADCUE state.

https://reviewboard.mozilla.org/r/199636/#review204958

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f276f1cc275
Modify .vtt REGION syntax. r=alwu
https://hg.mozilla.org/integration/autoland/rev/1786297a20df
Support multi-line parsing for REGION/STYLE block. r=alwu
https://hg.mozilla.org/integration/autoland/rev/5a9fbe6806cf
Correct the behavior for BADCUE state. r=alwu

Comment 15

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/0f276f1cc275
https://hg.mozilla.org/mozilla-central/rev/1786297a20df
https://hg.mozilla.org/mozilla-central/rev/5a9fbe6806cf

Comment 16

[Eric Shepherd [:sheppy]]

Firefox 59 for developers now notes this change.