1415961 - construct {Blur,Gradient}CacheData more efficiently

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Description

[Nathan Froyd [:froydnj]]

We pass in `const {Blur,Gradient}CacheKey&` to these functions.  There's
no need to copy the cache keys here; we can just Move() the existing
objects in instead.  Doing this saves unnecessary allocations and/or
refcounting.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: construct {Blur,Gradient}CacheData more efficiently

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0ddd9a98e74
construct {Blur,Gradient}CacheData more efficiently; r=jrmuizel

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for bustage in thebes:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef4baef9df841886af07530afb4fa1f8ae8e93ab

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d0ddd9a98e74e8c736f4f11ffb5a8ed32adb0bda&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=143450285&repo=mozilla-inbound
/builds/worker/workspace/build/src/gfx/thebes/gfxBlur.cpp:358:23: error: use of deleted function 'constexpr BlurCacheKey::BlurCacheKey(const BlurCacheKey&)'
/builds/worker/workspace/build/src/gfx/thebes/gfxGradientCache.cpp:98:23: error: use of deleted function 'mozilla::gfx::GradientCacheKey::GradientCacheKey(const mozilla::gfx::GradientCacheKey&)'

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e62f2933a39
construct {Blur,Gradient}CacheData more efficiently; r=jrmuizel

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8e62f2933a39