construct {Blur,Gradient}CacheData more efficiently

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed)

Details

Attachments

(1 attachment)

We pass in `const {Blur,Gradient}CacheKey&` to these functions.  There's
no need to copy the cache keys here; we can just Move() the existing
objects in instead.  Doing this saves unnecessary allocations and/or
refcounting.
Attachment #8926964 - Flags: review?(jmuizelaar) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0ddd9a98e74
construct {Blur,Gradient}CacheData more efficiently; r=jrmuizel
Backed out for bustage in thebes:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef4baef9df841886af07530afb4fa1f8ae8e93ab

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=d0ddd9a98e74e8c736f4f11ffb5a8ed32adb0bda&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=retry
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=143450285&repo=mozilla-inbound
/builds/worker/workspace/build/src/gfx/thebes/gfxBlur.cpp:358:23: error: use of deleted function 'constexpr BlurCacheKey::BlurCacheKey(const BlurCacheKey&)'
/builds/worker/workspace/build/src/gfx/thebes/gfxGradientCache.cpp:98:23: error: use of deleted function 'mozilla::gfx::GradientCacheKey::GradientCacheKey(const mozilla::gfx::GradientCacheKey&)'
Flags: needinfo?(nfroyd)
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e62f2933a39
construct {Blur,Gradient}CacheData more efficiently; r=jrmuizel
Flags: needinfo?(nfroyd)
https://hg.mozilla.org/mozilla-central/rev/8e62f2933a39
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.