Closed
Bug 1415971
Opened 4 years ago
Closed 4 years ago
Remove MOZ_PREFLIGHT_ALL / MOZ_POSTFLIGHT_ALL
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox58 fixed)
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: gps, Assigned: gps)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
The only thing that uses this is sccache.mk, which is only used in automation to manage the sccache daemon. We should be able to inline sccache.mk logic into `mach build` logic.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 5•4 years ago
|
||
mozreview-review |
Comment on attachment 8927037 [details] Bug 1415971 - Stop build output monitor earlier; https://reviewboard.mozilla.org/r/198244/#review203484
Attachment #8927037 -
Flags: review+
Comment 6•4 years ago
|
||
mozreview-review |
Comment on attachment 8927038 [details] Bug 1415971 - Dedent warning printing code; https://reviewboard.mozilla.org/r/198246/#review203486
Attachment #8927038 -
Flags: review+
Comment 7•4 years ago
|
||
mozreview-review |
Comment on attachment 8927039 [details] Bug 1415971 - Inline sccache.mk into client.mk; https://reviewboard.mozilla.org/r/198248/#review203488 That's gnarly. What's the plan for integrating tup with sccache?
Attachment #8927039 -
Flags: review+
Comment 8•4 years ago
|
||
mozreview-review |
Comment on attachment 8927040 [details] Bug 1415971 - Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL; https://reviewboard.mozilla.org/r/198250/#review203492 Nice to see this cruft getting whittled away.
Attachment #8927040 -
Flags: review+
Updated•4 years ago
|
Attachment #8927037 -
Flags: review?(core-build-config-reviews)
Attachment #8927038 -
Flags: review?(core-build-config-reviews)
Attachment #8927039 -
Flags: review?(core-build-config-reviews)
Attachment #8927040 -
Flags: review?(core-build-config-reviews)
Assignee | ||
Comment 9•4 years ago
|
||
mozreview-review-reply |
Comment on attachment 8927039 [details] Bug 1415971 - Inline sccache.mk into client.mk; https://reviewboard.mozilla.org/r/198248/#review203488 We may have to run a jobserver from a Rust binary. Apparently there is a crate that implements the jobserver protocol. But that's for another day.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•4 years ago
|
Attachment #8927039 -
Flags: review?(core-build-config-reviews)
Attachment #8927040 -
Flags: review?(core-build-config-reviews)
Comment 12•4 years ago
|
||
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/688d2bdee4cc Stop build output monitor earlier; r=nalexander https://hg.mozilla.org/integration/autoland/rev/30fbe1a0ce8c Dedent warning printing code; r=nalexander https://hg.mozilla.org/integration/autoland/rev/109cb09f0123 Inline sccache.mk into client.mk; r=nalexander https://hg.mozilla.org/integration/autoland/rev/512bc6565c80 Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL; r=nalexander
Comment 13•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/688d2bdee4cc https://hg.mozilla.org/mozilla-central/rev/30fbe1a0ce8c https://hg.mozilla.org/mozilla-central/rev/109cb09f0123 https://hg.mozilla.org/mozilla-central/rev/512bc6565c80
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Comment 14•4 years ago
|
||
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/140dc299f373 Keep build files in sync (Port bug 1415971: Inline sccache.mk into client.mk). rs=bustage-fix
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•