Remove MOZ_PREFLIGHT_ALL / MOZ_POSTFLIGHT_ALL

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

(Blocks 1 bug)

unspecified
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(4 attachments)

The only thing that uses this is sccache.mk, which is only used in automation to manage the sccache daemon.

We should be able to inline sccache.mk logic into `mach build` logic.
Comment on attachment 8927037 [details]
Bug 1415971 - Stop build output monitor earlier;

https://reviewboard.mozilla.org/r/198244/#review203484
Attachment #8927037 - Flags: review+
Comment on attachment 8927039 [details]
Bug 1415971 - Inline sccache.mk into client.mk;

https://reviewboard.mozilla.org/r/198248/#review203488

That's gnarly.  What's the plan for integrating tup with sccache?
Attachment #8927039 - Flags: review+
Comment on attachment 8927040 [details]
Bug 1415971 - Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL;

https://reviewboard.mozilla.org/r/198250/#review203492

Nice to see this cruft getting whittled away.
Attachment #8927040 - Flags: review+
Attachment #8927037 - Flags: review?(core-build-config-reviews)
Attachment #8927038 - Flags: review?(core-build-config-reviews)
Attachment #8927039 - Flags: review?(core-build-config-reviews)
Attachment #8927040 - Flags: review?(core-build-config-reviews)
Comment on attachment 8927039 [details]
Bug 1415971 - Inline sccache.mk into client.mk;

https://reviewboard.mozilla.org/r/198248/#review203488

We may have to run a jobserver from a Rust binary. Apparently there is a crate that implements the jobserver protocol. But that's for another day.
Attachment #8927039 - Flags: review?(core-build-config-reviews)
Attachment #8927040 - Flags: review?(core-build-config-reviews)
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/688d2bdee4cc
Stop build output monitor earlier; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/30fbe1a0ce8c
Dedent warning printing code; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/109cb09f0123
Inline sccache.mk into client.mk; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/512bc6565c80
Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL; r=nalexander
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/140dc299f373
Keep build files in sync (Port bug 1415971: Inline sccache.mk into client.mk). rs=bustage-fix
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.