1415971 - Remove MOZ_PREFLIGHT_ALL / MOZ_POSTFLIGHT_ALL

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Gregory Szorc [:gps]]

The only thing that uses this is sccache.mk, which is only used in automation to manage the sccache daemon.

We should be able to inline sccache.mk logic into `mach build` logic.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1415971 - Stop build output monitor earlier;

We currently print compiler warnings summary then stop the build
output manager, which basically stops resource monitoring.

A future commit will refactor this code a bit and it will be easier
to have the monitor.stop() call directly after the build finishes.

Review commit: https://reviewboard.mozilla.org/r/198244/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198244/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1415971 - Dedent warning printing code;

This doesn't need to run when the context manager is active.

Review commit: https://reviewboard.mozilla.org/r/198246/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198246/

Comment 3

[Gregory Szorc [:gps]]

Attachment: Bug 1415971 - Inline sccache.mk into client.mk;

sccache.mk is the only thing that uses MOZ_PREFLIGHT_ALL and
MOZ_POSTFLIGHT_ALL. We're trying to kill client.mk and these
variables are next on the chopping block.

This commit essentially moves the logic of sccache.mk inline into
client.mk. Initially, I wanted to move the management of the
sccache daemon to Python as part of what `mach build` invokes.
However, the sccache daemon needs access to the make jobserver.
Since we don't have an active make process in `mach`, this is
obviously problematic. The sccache daemon is also used by
configure, which is launched from client.mk. So the best we
can do right now is move the sccache daemon logic into client.mk.

As part of the port, we pass the path to the sccache binary via
an environment variable. This feels slightly better than hardcoding
the path that automation uses.

Review commit: https://reviewboard.mozilla.org/r/198248/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198248/

Comment 4

[Gregory Szorc [:gps]]

Attachment: Bug 1415971 - Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL;

After removing sccache.mk, there are no more references to these
variables. Let's nuke them.

Review commit: https://reviewboard.mozilla.org/r/198250/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198250/

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8927037 [details]
Bug 1415971 - Stop build output monitor earlier;

https://reviewboard.mozilla.org/r/198244/#review203484

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8927038 [details]
Bug 1415971 - Dedent warning printing code;

https://reviewboard.mozilla.org/r/198246/#review203486

Comment 7

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8927039 [details]
Bug 1415971 - Inline sccache.mk into client.mk;

https://reviewboard.mozilla.org/r/198248/#review203488

That's gnarly.  What's the plan for integrating tup with sccache?

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8927040 [details]
Bug 1415971 - Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL;

https://reviewboard.mozilla.org/r/198250/#review203492

Nice to see this cruft getting whittled away.

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8927039 [details]
Bug 1415971 - Inline sccache.mk into client.mk;

https://reviewboard.mozilla.org/r/198248/#review203488

We may have to run a jobserver from a Rust binary. Apparently there is a crate that implements the jobserver protocol. But that's for another day.

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8927039 [details]
Bug 1415971 - Inline sccache.mk into client.mk;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198248/diff/1-2/

Comment 11

[Gregory Szorc [:gps]]

Comment on attachment 8927040 [details]
Bug 1415971 - Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/198250/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/688d2bdee4cc
Stop build output monitor earlier; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/30fbe1a0ce8c
Dedent warning printing code; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/109cb09f0123
Inline sccache.mk into client.mk; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/512bc6565c80
Remove MOZ_PREFLIGHT_ALL and MOZ_POSTFLIGHT_ALL; r=nalexander

Comment 13

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/688d2bdee4cc
https://hg.mozilla.org/mozilla-central/rev/30fbe1a0ce8c
https://hg.mozilla.org/mozilla-central/rev/109cb09f0123
https://hg.mozilla.org/mozilla-central/rev/512bc6565c80

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/140dc299f373
Keep build files in sync (Port bug 1415971: Inline sccache.mk into client.mk). rs=bustage-fix