1415974 - Add the new quiet entry in the Page Info panel for Flash -- worded as "Hide"

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Screen Shot 2017-11-09 at 6.08.33 PM.png

Flash has a new mode, Quiet, from bug 1398972, which is a bit different than Block.

- Quiet show the grey plug-in overlay, but it still reserves the plugin space, and it allows the user to activate the plugin by clicking in the URL bar icon

- Block doesn't reserve the plug-in space and doesn't allow the user to activate the plugin at all


I suggest we call this "Hide". See the screenshot for the patch. We must land this string before 58 goes to Beta next week.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

(In reply to :Felipe Gomes (needinfo me!) from comment #0)
> - Quiet show the grey plug-in overlay, but it still reserves the plugin
> space, and it allows the user to activate the plugin by clicking in the URL
> bar icon

Err, I meant, Quiet *doesn't* show the grey plug-in overlay

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1415974 - Add Hide entry in the Page Info panel for plug-ins.

Review commit: https://reviewboard.mozilla.org/r/198210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198210/

Comment 3

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8926983 [details]
Bug 1415974 - Add Hide entry in the Page Info panel for plug-ins.

https://reviewboard.mozilla.org/r/198210/#review203528

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e581ff7ea38
Add Hide entry in the Page Info panel for plug-ins. r=dthayer

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0e581ff7ea38

Comment 6

[Bram Pitoyo [:bram]]

Comment on attachment 8926980 [details]
Screen Shot 2017-11-09 at 6.08.33 PM.png

Ideally, in the future, the states would be simplified to just three:

* Allow
* Ask
* Block

Quiet is an intermediary state to get to this simplification. It means “Ask me again when the page refreshes”. It can be accessed by unchecking the “Remember my decision” checkbox then clicking the “Not Now” button.

(Note that these 3 states refer to ones that the user can see on the UI. Firefox itself can still have many states to handle all the variations in behaviours, as long as we ultimately show users just 3. We need to keep this goal in mind for future discussion and works.)