Closed Bug 1415978 Opened 2 years ago Closed 2 years ago

Change "Activate Adobe Flash" to "Run Adobe Flash" in the overlay UI

Categories

(Core :: Plug-ins, defect)

58 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(2 files)

As requested in bug 1409148. Since it wasn't clear if that was gonna be uplifted or not (in the end, it wasn't), the string change was left for a separate bug.
Attached image "Run Adobe Flash"
Bram, besides doing the change, I added a localization note to the new string. Let me know what you think about it:

> # LOCALIZATION NOTE (PluginClickToActivate2): Two changes were done to the
> # previous version of the string. The first is that we changed the wording from
> # "Activate" to "Run", because it's shorter and feels less technical in English.
> # Feel free to keep using the previous wording in your language if it's already
> # the best one.
> # The second change is that we removed the period at the end of the phrase, because
> # it's not natural in our UI, and the underline was removed from this, so it doesn't
> # look like a link anymore. We suggest that everyone removes that period too.
Attachment #8926993 - Flags: ui-review?(bram)
Comment on attachment 8926992 [details]
Bug 1415978 - Change 'Activate Adobe Flash' to 'Run Adobe Flash' in the overlay UI.

https://reviewboard.mozilla.org/r/198214/#review203526
Attachment #8926992 - Flags: review?(dothayer) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/5d321835674f
Change 'Activate Adobe Flash' to 'Run Adobe Flash' in the overlay UI. r=dthayer
https://hg.mozilla.org/mozilla-central/rev/5d321835674f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
FWIW, I landed this before getting the ui-review from Bram because I wanted to make sure the string landed before 58 goes to beta. I had already talked with Bram and the plan was always to make this change.
Yes. Confirming that Felipe and I had talked about and agreed to this change.
Attachment #8926993 - Flags: ui-review?(bram) → ui-review+
You need to log in before you can comment on or make changes to this bug.