1415978 - Change "Activate Adobe Flash" to "Run Adobe Flash" in the overlay UI

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

As requested in bug 1409148. Since it wasn't clear if that was gonna be uplifted or not (in the end, it wasn't), the string change was left for a separate bug.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1415978 - Change 'Activate Adobe Flash' to 'Run Adobe Flash' in the overlay UI.

Review commit: https://reviewboard.mozilla.org/r/198214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198214/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Attachment: "Run Adobe Flash"

Bram, besides doing the change, I added a localization note to the new string. Let me know what you think about it:

> # LOCALIZATION NOTE (PluginClickToActivate2): Two changes were done to the
> # previous version of the string. The first is that we changed the wording from
> # "Activate" to "Run", because it's shorter and feels less technical in English.
> # Feel free to keep using the previous wording in your language if it's already
> # the best one.
> # The second change is that we removed the period at the end of the phrase, because
> # it's not natural in our UI, and the underline was removed from this, so it doesn't
> # look like a link anymore. We suggest that everyone removes that period too.

Comment 3

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8926992 [details]
Bug 1415978 - Change 'Activate Adobe Flash' to 'Run Adobe Flash' in the overlay UI.

https://reviewboard.mozilla.org/r/198214/#review203526

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d321835674f
Change 'Activate Adobe Flash' to 'Run Adobe Flash' in the overlay UI. r=dthayer

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5d321835674f

Comment 6

[:Felipe Gomes (needinfo for replies!)]

FWIW, I landed this before getting the ui-review from Bram because I wanted to make sure the string landed before 58 goes to beta. I had already talked with Bram and the plan was always to make this change.

Comment 7

[Bram Pitoyo [:bram]]

Yes. Confirming that Felipe and I had talked about and agreed to this change.