1416020 - Remove some cruft from client.mk

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1416020 - Remove unused variables from client.mk;

The last use of PERL was removed recently.

The last use of comma was removed by c8276e89a513 in 2008.

The last use of SH was... never AFAICT. The variable was
defined but unused in the initial import of client.mk from CVS
in 1998.

Review commit: https://reviewboard.mozilla.org/r/198262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198262/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1416020 - Remove echo-variable-% target from client.mk;

AFAICT this is unused.

There are some mozharness consumers that evaluate an echo-variable-*
target. However, I believe they are hitting the target from debugmake.mk
and not going through client.mk.

Review commit: https://reviewboard.mozilla.org/r/198264/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198264/

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8927051 [details]
Bug 1416020 - Remove unused variables from client.mk;

https://reviewboard.mozilla.org/r/198262/#review203506

Stamp!

::: client.mk
(Diff revision 1)
>  #   MOZ_MAKE_FLAGS       - Flags to pass to $(MAKE)
>  #
>  #######################################################################
>  # Defines
>  
> -comma := ,

Looks like there's another unused `COMMA`: http://searchfox.org/mozilla-central/search?q=comma%5B%5En%5D&case=false&regexp=true&path=*.mk.

::: client.mk
(Diff revision 1)
>  TOPSRCDIR := $(CWD)
>  endif
>  endif
>  
> -SH := /bin/sh
> -PERL ?= perl

Does this not interact with http://searchfox.org/mozilla-central/source/config/version.mk#46?

Comment 4

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8927052 [details]
Bug 1416020 - Remove echo-variable-% target from client.mk;

https://reviewboard.mozilla.org/r/198264/#review203508

If it's green in try, it's OK by me.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8927051 [details]
Bug 1416020 - Remove unused variables from client.mk;

https://reviewboard.mozilla.org/r/198262/#review203506

> Looks like there's another unused `COMMA`: http://searchfox.org/mozilla-central/search?q=comma%5B%5En%5D&case=false&regexp=true&path=*.mk.

We'll get to it another day.

> Does this not interact with http://searchfox.org/mozilla-central/source/config/version.mk#46?

AFAICT version.mk is only included by rules.mk. And rules.mk is not included by client.mk. So we should be fine.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db9cecd33c00
Remove unused variables from client.mk; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/5f3ad5cd8060
Remove echo-variable-% target from client.mk; r=nalexander

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/db9cecd33c00
https://hg.mozilla.org/mozilla-central/rev/5f3ad5cd8060