Closed Bug 1416020 Opened 2 years ago Closed 2 years ago

Remove some cruft from client.mk

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Comment on attachment 8927051 [details]
Bug 1416020 - Remove unused variables from client.mk;

https://reviewboard.mozilla.org/r/198262/#review203506

Stamp!

::: client.mk
(Diff revision 1)
>  #   MOZ_MAKE_FLAGS       - Flags to pass to $(MAKE)
>  #
>  #######################################################################
>  # Defines
>  
> -comma := ,

Looks like there's another unused `COMMA`: http://searchfox.org/mozilla-central/search?q=comma%5B%5En%5D&case=false&regexp=true&path=*.mk.

::: client.mk
(Diff revision 1)
>  TOPSRCDIR := $(CWD)
>  endif
>  endif
>  
> -SH := /bin/sh
> -PERL ?= perl

Does this not interact with http://searchfox.org/mozilla-central/source/config/version.mk#46?
Attachment #8927051 - Flags: review+
Comment on attachment 8927052 [details]
Bug 1416020 - Remove echo-variable-% target from client.mk;

https://reviewboard.mozilla.org/r/198264/#review203508

If it's green in try, it's OK by me.
Attachment #8927052 - Flags: review+
Attachment #8927051 - Flags: review?(core-build-config-reviews)
Attachment #8927052 - Flags: review?(core-build-config-reviews)
Comment on attachment 8927051 [details]
Bug 1416020 - Remove unused variables from client.mk;

https://reviewboard.mozilla.org/r/198262/#review203506

> Looks like there's another unused `COMMA`: http://searchfox.org/mozilla-central/search?q=comma%5B%5En%5D&case=false&regexp=true&path=*.mk.

We'll get to it another day.

> Does this not interact with http://searchfox.org/mozilla-central/source/config/version.mk#46?

AFAICT version.mk is only included by rules.mk. And rules.mk is not included by client.mk. So we should be fine.
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db9cecd33c00
Remove unused variables from client.mk; r=nalexander
https://hg.mozilla.org/integration/autoland/rev/5f3ad5cd8060
Remove echo-variable-% target from client.mk; r=nalexander
https://hg.mozilla.org/mozilla-central/rev/db9cecd33c00
https://hg.mozilla.org/mozilla-central/rev/5f3ad5cd8060
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.